[fiber] Hide manual stack watermarking to avoid misuse

Author: salkinium

examples/generic/fiber/main.cpp

@@ -90,12 +90,10 @@ main()
 	MODM_LOG_INFO << "Starting fiber modm::yield benchmark..." << modm::endl;
 	MODM_LOG_INFO.flush();
 
-	fiber_y1.stack_watermark();
-	fiber_y2.stack_watermark();
 	// fiber_y1, fiber_y2 were autostarted
 	{
 		modm::atomic::Lock l;
-		modm::fiber::Scheduler::run();
+		modm::fiber::Scheduler::run(modm::fiber::Scheduler::AutoWatermark);
 	}
 
 	MODM_LOG_INFO << "Y1 stack usage: = " << fiber_y1.stack_usage() << modm::endl;
@@ -125,10 +123,8 @@ main()
 	MODM_LOG_INFO << "F3 stack usage = " << fiber3.stack_usage() << modm::endl;
 	MODM_LOG_INFO << "F4 stack usage = " << fiber4.stack_usage() << modm::endl;
 
-	fiber_ping.stack_watermark();
-	fiber_pong.stack_watermark();
 	fiber_ping.start();
-	modm::fiber::Scheduler::run();
+	modm::fiber::Scheduler::run(modm::fiber::Scheduler::AutoWatermark);
 
 	while(1) ;
 	return 0;

examples/nucleo_g071rb/amnb/main.cpp

@@ -137,14 +137,7 @@ main()
 	USART4->CR3 = USART_CR3_HDSEL;
 	USART4->CR1 |= USART_CR1_UE;
 
-	fiberNode1t.stack_watermark();
-	fiberNode1r.stack_watermark();
-	fiberNode2t.stack_watermark();
-	fiberNode2r.stack_watermark();
-	fiberNode3t.stack_watermark();
-	fiberNode3r.stack_watermark();
-
-	modm::fiber::Scheduler::run();
+	modm::fiber::Scheduler::run(modm::fiber::Scheduler::AutoWatermark);
 
 	return 0;
 }

src/modm/processing/fiber/task.hpp

@@ -125,15 +125,6 @@ class Task
 		return stop.request_stop();
 	}
 
-
-	/// Watermarks the stack to measure `stack_usage()` later.
-	/// @see `modm_context_stack_watermark()`.
-	void inline
-	stack_watermark()
-	{
-		modm_context_stack_watermark(&ctx);
-	}
-
 	/// @returns the stack usage as measured by a watermark level.
 	/// @see `modm_context_stack_usage()`.
 	[[nodiscard]] size_t inline
@@ -163,6 +154,13 @@ class Task
 	}
 
 	/// @cond
+	// Always use Scheduler::run(Scheduler::AutoWatermark) instead!
+	// For performance sensitive use cases you may call this function manually.
+	void inline
+	stack_watermark()
+	{
+		modm_context_stack_watermark(&ctx);
+	}
 	// DEPRECATE: 2025q4
 	[[deprecated("Use `stack_watermark()` instead!")]]
 	void inline watermark_stack() { stack_watermark(); }