Additional Booking Tests

Author: cj-ballesteros

backend/apps/bookings/models.py

@@ -4,7 +4,7 @@
 import uuid
 from datetime import timedelta
 from django.utils.timezone import now
-from rest_framework.exceptions import ValidationError
+from django.core.exceptions import ValidationError
 from apps.users.models import TutorProfile
 from apps.bookings.managers import ReviewManager, BookingManager
 

backend/apps/bookings/tests.py

@@ -1,6 +1,7 @@
 from django.test import TestCase
 from django.contrib.auth.models import User
 from django.utils.timezone import now, timedelta
+from django.core.exceptions import ValidationError
 from apps.users.models import TutorProfile, Profile
 from apps.bookings.models import Booking, Availability, Review
 from rest_framework.test import APITestCase, APIClient
@@ -69,6 +70,65 @@ def test_booking_cancellation(self):
         self.assertEqual(booking.booking_status, Booking.CANCELLED)
         self.assertFalse(updated_availability.is_booked)
 
+    def test_clean_raises_without_availability(self):
+        booking = Booking(
+            student=self.student_user,
+            session_price=20.00,
+            availability=None
+        )
+        with self.assertRaises(ValidationError) as ctx:
+            booking.clean()
+        self.assertIn("must be linked to an availability", str(ctx.exception))
+
+    def test_clean_raises_if_availability_already_booked(self):
+        self.availability.is_booked = True
+        self.availability.save()
+
+        booking = Booking(
+            student=self.student_user,
+            session_price=20.00,
+            availability=self.availability
+        )
+        with self.assertRaises(ValidationError) as ctx:
+            booking.clean()
+        self.assertIn("already booked", str(ctx.exception))
+
+    def test_save_does_not_book_if_cancelled(self):
+        booking = Booking.objects.create(
+            student=self.student_user,
+            session_price=25.00,
+            availability=self.availability,
+            booking_status=Booking.CANCELLED
+        )
+        booking.refresh_from_db()
+        self.availability.refresh_from_db()
+        self.assertFalse(self.availability.is_booked)
+
+    def test_save_marks_availability_as_booked_unless_cancelled(self):
+        booking = Booking.objects.create(
+            student=self.student_user,
+            session_price=25.00,
+            availability=self.availability,
+            booking_status=Booking.APPROVED
+        )
+        self.availability.refresh_from_db()
+        self.assertTrue(self.availability.is_booked)
+
+    def test_booking_detail_serializer_includes_read_only_booking(self):
+        from apps.bookings.serializers import BookingDetailSerializer
+
+        booking = Booking.objects.create(
+            student=self.student_user,
+            session_price=30.00,
+            availability=self.availability
+        )
+
+        serializer = BookingDetailSerializer(instance=booking)
+        data = serializer.data
+        self.assertIn("student", data)
+        self.assertEqual(data["student_username"], self.student_user.username)
+
+
 class BookingAPITestCase(APITestCase):
     def setUp(self):
         # Create tutor and tutor profile
@@ -137,4 +197,62 @@ def test_get_availability_by_tutor_and_date(self):
         date_str = self.availability.start_time.strftime("%Y-%m-%d")
         url = f"/bookings/availability/?tutor_id={self.tutor.id}&date={date_str}"
         response = self.client.get(url)
-        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+    def test_patch_booking_status(self):
+        new_availability = Availability.objects.create(
+            tutor=self.tutor,
+            start_time=now() + timedelta(days=2),
+            end_time=now() + timedelta(days=2, hours=1),
+            is_booked=False
+        )
+
+        booking = Booking.objects.create(
+            student=self.student_user,
+            session_price=30.00,
+            availability=new_availability
+        )
+
+        # Reset to unbooked for PATCH to
+
+    def test_put_booking(self):
+        new_availability = Availability.objects.create(
+            tutor=self.tutor,
+            start_time=now() + timedelta(days=3),
+            end_time=now() + timedelta(days=3, hours=1),
+            is_booked=False
+        )
+
+        booking = Booking.objects.create(
+            student=self.student_user,
+            session_price=25.00,
+            availability=new_availability
+        )
+
+        # Reset booking state for validation to pass
+        new_availability.is_booked = False
+        new_availability.save()
+
+        url = f"/bookings/bookings_list/{booking.payment_gateway_ref}/"
+        data = {
+            "session_price": "35.00",
+            "availability": new_availability.id,
+            "booking_status": Booking.FULFILLED
+        }
+
+        response = self.client.put(url, data, format="json")
+        booking.refresh_from_db()
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertEqual(float(booking.session_price), 35.00)
+        self.assertEqual(booking.booking_status, Booking.FULFILLED)
+
+    def test_delete_booking(self):
+        booking = Booking.objects.create(
+            student=self.student_user,
+            session_price=30.00,
+            availability=self.availability
+        )
+        url = f"/bookings/bookings_list/{booking.payment_gateway_ref}/"
+        response = self.client.delete(url)
+        self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)
+        self.assertFalse(Booking.objects.filter(pk=booking.payment_gateway_ref).exists())