Commit fb9d2d3
authored
fix: feedback on GOES interface (#281)
# Description:
This PR addresses several UI/UX improvements and bug fixes for the GOES
Plume Viewer, focusing on date filtering functionality and animation
timeline improvements.
# Changes:
1. Date Picker Temporal Extent Restrictions (Commit: 0eb8684)
Implemented dynamic calculation of min/max dates from regions data and
added constraints to DatePicker components to grey out dates outside the
available data range. Added reset functionality to restore date range
when the home button is clicked, preventing users from selecting dates
with no available data.
2. Animation Timeline First Plume Display Fix (Commit: e51e64f)
Resolved issue where the first plume would disappear when dragging the
animation slider to the beginning by moving the initial plume display
call outside of the timeline onStart handler, ensuring proper rendering
before timeline initialization.
3. Measurement Tool Icon Visibility Fix (Commit: 140ccdf)
Fixed ruler icon turning white and blending with button background when
selected by replacing the undefined CSS variable with the correct color
variable, ensuring proper contrast between icon and button background.
4. Animation Replay Button Fix (Commit: 005d427)
Fixed replay button incorrectly restarting the animation from the middle
of the timeline instead of the beginning. The issue was caused by the
[mapboxgl-timeline](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html)
library passing a string value to the Date constructor. Applied a monkey
patch to correctly parse the slider's minimum value as a number, and
updated the onStart callback to properly reset animation state and clear
all buffered layers.
PR is made on the timeline library too.
[ref](markusand/mapboxgl-timeline#2)File tree
4 files changed
+69
-18
lines changed- goes-plume-viewer/src
- components
- filter
- mapControls
- plumeAnimation
- pages/dashboard
4 files changed
+69
-18
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
8 | 46 | | |
9 | 47 | | |
10 | 48 | | |
| |||
44 | 82 | | |
45 | 83 | | |
46 | 84 | | |
| 85 | + | |
| 86 | + | |
47 | 87 | | |
48 | 88 | | |
49 | 89 | | |
| |||
67 | 107 | | |
68 | 108 | | |
69 | 109 | | |
| 110 | + | |
| 111 | + | |
70 | 112 | | |
71 | 113 | | |
72 | 114 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
Lines changed: 17 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
36 | 39 | | |
37 | 40 | | |
38 | 41 | | |
39 | 42 | | |
40 | 43 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | 44 | | |
54 | 45 | | |
55 | 46 | | |
| |||
67 | 58 | | |
68 | 59 | | |
69 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
70 | 75 | | |
71 | 76 | | |
72 | 77 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
| |||
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
| 128 | + | |
127 | 129 | | |
128 | 130 | | |
129 | 131 | | |
| |||
185 | 187 | | |
186 | 188 | | |
187 | 189 | | |
| 190 | + | |
| 191 | + | |
188 | 192 | | |
189 | 193 | | |
190 | 194 | | |
| |||
0 commit comments