remove hard coded screenshot path

buggtb · buggtb · commit b18d56e8f155 · 2021-05-04T13:29:07.000+01:00
diff --git a/sparkler-core/sparkler-plugins/fetcher-chrome/src/main/java/edu/usc/irds/sparkler/plugin/FetcherChrome.java b/sparkler-core/sparkler-plugins/fetcher-chrome/src/main/java/edu/usc/irds/sparkler/plugin/FetcherChrome.java
@@ -239,7 +239,7 @@ public FetchedData fetch(Resource resource) throws Exception {
                 } catch (Exception e){
                     Map<String, Object> tempmap = new HashMap<>();
                     tempmap.put("type", "file");
-                    tempmap.put("targetdir", "/dbfs/FileStore/screenshots/"+resource.getCrawlId()+System.currentTimeMillis());
+                    tempmap.put("targetdir", pluginConfig.getOrDefault("chrome.selenium.screenshotdir","/dbfs/FileStore/screenshots/")+resource.getCrawlId()+System.currentTimeMillis());
                     scripter.screenshot(tempmap);
                     e.printStackTrace();
                 }

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ public FetchedData fetch(Resource resource) throws Exception {`
`239`	`239`	`} catch (Exception e){`
`240`	`240`	`Map<String, Object> tempmap = new HashMap<>();`
`241`	`241`	`tempmap.put("type", "file");`
`242`		`- tempmap.put("targetdir", "/dbfs/FileStore/screenshots/"+resource.getCrawlId()+System.currentTimeMillis());`
	`242`	`+ tempmap.put("targetdir", pluginConfig.getOrDefault("chrome.selenium.screenshotdir","/dbfs/FileStore/screenshots/")+resource.getCrawlId()+System.currentTimeMillis());`
`243`	`243`	`scripter.screenshot(tempmap);`
`244`	`244`	`e.printStackTrace();`
`245`	`245`	`}`