CRAN accepted

Author: gvegayon

CRAN-RELEASE

@@ -1,2 +1,2 @@
-This package was submitted to CRAN on 2019-10-14.
-Once it is accepted, delete this file and tag the release (commit 933f714c9a).
+This package was submitted to CRAN on 2019-12-19.
+Once it is accepted, delete this file and tag the release (commit a311f5a00a).

R/options.R

@@ -17,42 +17,42 @@
 #'
 #' Debugging mode
 #'
-#' - `debug_on : function ()` \Sexpr{attr(slurmR::opts_slurmR$debug_on, "desc")}
+#' - `debug_on : function ()` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$debug_on, "desc")}
 #'
-#' - `debug_off : function ()` \Sexpr{attr(slurmR::opts_slurmR$debug_off, "desc")}
+#' - `debug_off : function ()` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$debug_off, "desc")}
 #'
-#' - `get_debug : function ()` \Sexpr{attr(slurmR::opts_slurmR$get_debug, "desc")}
+#' - `get_debug : function ()` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$get_debug, "desc")}
 #'
 #' Verbose mode
 #'
-#' - `verbose_on : function ()` \Sexpr{attr(slurmR::opts_slurmR$verbose_on, "desc")}
+#' - `verbose_on : function ()` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$verbose_on, "desc")}
 #'
-#' - `verbose_off : function ()` \Sexpr{attr(slurmR::opts_slurmR$verbose_off, "desc")}
+#' - `verbose_off : function ()` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$verbose_off, "desc")}
 #'
-#' - `get_verbose : function ()` \Sexpr{attr(slurmR::opts_slurmR$get_verbose, "desc")}
+#' - `get_verbose : function ()` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$get_verbose, "desc")}
 #'
 #' Slurm options
 #'
-#' - `set_tmp_path : function (path, recursive = TRUE)` \Sexpr{attr(slurmR::opts_slurmR$set_tmp_path, "desc")}
+#' - `set_tmp_path : function (path, recursive = TRUE)` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$set_tmp_path, "desc")}
 #'
-#' - `get_tmp_path : function ()` \Sexpr{attr(slurmR::opts_slurmR$get_tmp_path, "desc")}
+#' - `get_tmp_path : function ()` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$get_tmp_path, "desc")}
 #'
-#' - `set_job_name : function (path, check = TRUE, overwrite = TRUE)` \Sexpr{attr(slurmR::opts_slurmR$set_job_name, "desc")}.
+#' - `set_job_name : function (path, check = TRUE, overwrite = TRUE)` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$set_job_name, "desc")}.
 #'
-#' - `get_job_name : function (check = TRUE)` \Sexpr{attr(slurmR::opts_slurmR$get_job_name, "desc")}
+#' - `get_job_name : function (check = TRUE)` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$get_job_name, "desc")}
 #'
 #' Other options
 #'
-#' - `get_cmd : function ()` \Sexpr{attr(slurmR::opts_slurmR$get_cmd, "desc")}
+#' - `get_cmd : function ()` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$get_cmd, "desc")}
 #'
 #'
 #' For general set/retrieve options
 #'
-#' - `set_opts : function (...)` \Sexpr{attr(slurmR::opts_slurmR$set_opts, "desc")}
+#' - `set_opts : function (...)` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$set_opts, "desc")}
 #'
-#' - `get_opts_job : function (...)` \Sexpr{attr(slurmR::opts_slurmR$get_opts_job, "desc")}
+#' - `get_opts_job : function (...)` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$get_opts_job, "desc")}
 #'
-#' - `get_opts_r : function (...)` \Sexpr{attr(slurmR::opts_slurmR$get_opts_r, "desc")}
+#' - `get_opts_r : function (...)` \Sexpr[stage=build]{attr(slurmR::opts_slurmR$get_opts_r, "desc")}
 #'
 #'
 #' @examples

R/utils.R

@@ -389,7 +389,7 @@ Slurm_clean <- function(x) {
 #' Information about where jobs are submitted
 #'
 #' This returns a named vector with the following variables:
-#' \Sexpr{paste(names(slurmR::WhoAmI()), collapse = ", ")}
+#' \Sexpr[stage=build]{paste(names(slurmR::WhoAmI()), collapse = ", ")}
 #' @export
 #' @return A character vector with the corresponding system environment variables'
 #' values.

cran-comments.md

@@ -7,6 +7,9 @@
 * AppVeyor: Windows x86_64-w64-mingw32/x64 (64-bit) R 3.6.2 Patched (2019-12-14 r77584)
 * win-builder (CRAN): x86_64-w64-mingw32 (64-bit), R 3.6.1 (2019-07-05)
 * win-builder (CRAN): x86_64-w64-mingw32 (64-bit), R Under development (unstable) (2019-12-18 r77602)
+* R-hub builder: Ubuntu 16.04, R-release
+* R-hub builder: Fedora Linux, R-release
+* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
 
 ## R CMD check results
 
@@ -27,15 +30,12 @@ package and use some of its functions.
 
 ## On previous CRAN comments
 
-1. The "invalid URLs: URL: https://rc.hms.harvard.edu/" still shows a note on R
-   CMD check. A false positive.
+1. Last submission included the note: "Package has help file(s) containing
+   install/render-stage \Sexpr{} expressions but no prebuilt PDF manual."
+   Evaluation of the Sexpr is now done during the building process. I don't
+   see such message now.
 
-2. On the package's name. I've contacted the team behind Slurm and, unfortunately,
-   they asked me to change the name. Because of this, the R package is now called
-   slurmR. Besides of the name, all documentation has been updated to reflect this
-   change.
-   
-3. Errors while running tests on windows are now fixed.
+   I've also added R-hub checks. All is working OK.
 
 Thanks