adding changes to ylim and xlim(gsplot) from #246

Author: Jordan S Read

R/access-gsplot.R

@@ -12,7 +12,9 @@ xlim <- function(object) UseMethod("xlim")
 #' @export
 xlim.gsplot <- function(object){
 
-  lapply(views(object), function(x) x$window$xlim)
+  names = unname(sapply(views(object), function(x) paste0('side.',x$window$side[1])))
+  lapply(views(object), function(x) x$window$xlim) %>% 
+    setNames(names)
 }
 
 #' ylim for gsplot
@@ -27,7 +29,9 @@ ylim <- function(object) UseMethod("ylim")
 #' @export
 ylim.gsplot <- function(object){
 
-  lapply(views(object), function(x) x$window$ylim)
+  names = unname(sapply(views(object), function(x) paste0('side.',x$window$side[2])))
+  lapply(views(object), function(x) x$window$ylim) %>% 
+    setNames(names)
 }
 
 #' log for gsplot

README_files/figure-markdown_github/unnamed-chunk-2-1.png

@@ -23,6 +23,17 @@ test_that("xlim for dual axis", {
 
 })
 
+test_that("xlim for string input", {
+  
+  usrDef <- gsplot(mar=c(4,4,4,4), xaxs='r', yaxs='r') %>% 
+    points(x=1, y=2, side=c(3,2), legend.name="Points 1", cex=3, xlab='cat') %>% 
+    points(x=3:10,y=4:11, side=c(1,2))
+  
+  expect_equal(xlim(usrDef)[['side.3']], c(1,1))
+  expect_equal(xlim(usrDef)[['side.1']], c(3,10))
+  
+})
+
 context("test get par for gsplot object")
 
 test_that("par for simple object",{