Issue #1587: Fixes a bug in the JSON API for jobs #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a `,` for every element in our jobs array - Updates formatting to see the liquid logic more clearly - Moves nowunix capture outside of the for loop for jobs
Contributor
crd477
approved these changes
Nov 18, 2024
Contributor
crd477
left a comment
crd477
left a comment
There was a problem hiding this comment.
This LGTM. Is it OK by you to merge it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current
jobs.yml, we are missing a,after our last job object in our generated JSON at https://us-rse.org/api/jobs.json.Description
The JSON API for the jobs occasionally misses a
,after our last jobs object due the to way we sort. It seems to happen if the last non-expired job in ourjobs.ymlhas a posted date that is earlier than other jobs that are not expired. This should fix #1587 by enforcing a,at the end of every object in the JSON and ending the array with an empty object i.e.{}.,for every element in our jobs arrayChecklist:
When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.