@@ -64,16 +64,12 @@ During the PR review process, we make use of GitHub comments to track suggestion
6464The general principles are the following:
6565
6666- If the comment is a change suggestion...
67-
68- - If it's clear and uncontroversial how to apply the suggestion, you should resolve the comment after you have made
67+ - If it's clear and uncontroversial how to apply the suggestion, you should resolve the comment after you have made
6968 the corresponding changes to the PR.
70-
71- - If you are not 100% sure that you have applied the suggestion correctly, leave a comment asking it. Do not resolve
69+ - If you are not 100% sure that you have applied the suggestion correctly, leave a comment asking it. Do not resolve
7270 the comment in this case.
73-
74- - If you don't fully understand or agree with the suggestion, reply to the comment with your questions and
71+ - If you don't fully understand or agree with the suggestion, reply to the comment with your questions and
7572 rebuttals. Do not resolve the comment in this case.
76-
7773- If the comment is a clarification request, answer it. Do not resolve the comment in this case. We will either come
7874 back with further questions or suggestions, or close the comment ourselves if we find your answer satisfactory.
7975
@@ -89,5 +85,3 @@ tests is a waste of time for everyone involved.
8985During code review, it is not supposed to happen that we have to keep coming back to your PR, continually finding more
9086problems more unpolished changes, and having to go through lots of back-and-forth interactions this way. This will only
9187lead to growing frustration on both ends.
92-
93-
0 commit comments