Skip to content

Commit 7fc415f

Browse files
committed
docs(ci): document detect-quota limitation and reference allow-failure issue
Note that enabling continue-on-error on detect-quota forces a success result and can make the workflow report as failed; link to actions/runner#2347.
1 parent 4c15d67 commit 7fc415f

File tree

3 files changed

+24
-0
lines changed

3 files changed

+24
-0
lines changed

.github/workflows/check.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,14 @@ jobs:
1616
run: |
1717
echo "probe"
1818
19+
# NOTE: Do not set `continue-on-error: true` on the `detect-quota` job.
20+
# If `continue-on-error` is enabled the job result will always be
21+
# 'success', which defeats detection (we rely on `needs.detect-quota.result`).
22+
# Unfortunately this means the workflow may be reported as failed if the
23+
# hosted runner is unavailable. We cannot work around this until GitHub
24+
# provides a job-level "allow-failure"/neutral-conclusion feature
25+
# (see: https://github.com/actions/runner/issues/2347 for discussion).
26+
1927
eslint:
2028
# ESLint job inlined from check-shared-steps.yml
2129
needs: detect-quota

.github/workflows/docker.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@ jobs:
2626
run: |
2727
echo "probe"
2828
29+
# NOTE: Do not set `continue-on-error: true` on the `detect-quota` job.
30+
# If `continue-on-error` is enabled the job result will always be
31+
# 'success', which defeats detection (we rely on `needs.detect-quota.result`).
32+
# Unfortunately this means the workflow may be reported as failed if the
33+
# hosted runner is unavailable. We cannot work around this until GitHub
34+
# provides a job-level "allow-failure"/neutral-conclusion feature
35+
# (see: https://github.com/actions/runner/issues/2347 for discussion).
36+
2937
docker:
3038
needs: detect-quota
3139
if: ${{ always() }}

.github/workflows/release.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@ jobs:
2626
run: |
2727
echo "probe"
2828
29+
# NOTE: Do not set `continue-on-error: true` on the `detect-quota` job.
30+
# If `continue-on-error` is enabled the job result will always be
31+
# 'success', which defeats detection (we rely on `needs.detect-quota.result`).
32+
# Unfortunately this means the workflow may be reported as failed if the
33+
# hosted runner is unavailable. We cannot work around this until GitHub
34+
# provides a job-level "allow-failure"/neutral-conclusion feature
35+
# (see: https://github.com/actions/runner/issues/2347 for discussion).
36+
2937
release_please:
3038
needs: detect-quota
3139
if: ${{ always() }}

0 commit comments

Comments
 (0)