Skip to content

Commit 3c13d62

Browse files
committed
Fix the bug where switching semesters does not reset the form offeringIds and form courses
1 parent ae16a8f commit 3c13d62

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

course-matrix/frontend/src/pages/TimetableBuilder/Calendar.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,14 +156,19 @@ const Calendar = React.memo<CalendarProps>(
156156
const { data: numberOfSectionsData } = useGetNumberOfCourseSectionsQuery({
157157
course_ids: selectedCourseIds.join(","),
158158
semester: semester,
159+
}, {
160+
skip: !selectedCourses.length,
159161
});
160162

161-
const totalNumberOfSections =
162-
numberOfSectionsData?.totalNumberOfCourseSections ?? 0;
163+
const totalNumberOfSections = !selectedCourses.length ? 0 : (numberOfSectionsData?.totalNumberOfCourseSections ?? 0);
163164

164165
const allOfferingSectionsHaveBeenSelected =
165166
newOfferingIds.length === totalNumberOfSections;
166167

168+
169+
console.log("TOTAL NUMBER OF SECTIONS", totalNumberOfSections);
170+
console.log("NEW OFFERING IDS", newOfferingIds);
171+
167172
useEffect(() => {
168173
if (!isEditingTimetable) {
169174
return;

course-matrix/frontend/src/pages/TimetableBuilder/TimetableBuilder.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,10 @@ const TimetableBuilder = () => {
305305
<FormLabel>Semester</FormLabel>
306306
<FormControl>
307307
<Select
308-
onValueChange={field.onChange}
308+
onValueChange={(value) => {
309+
form.reset({ offeringIds: [], courses: [] });
310+
form.setValue("semester", value);
311+
}}
309312
value={field.value}
310313
defaultValue={field.value}
311314
>

0 commit comments

Comments
 (0)