Skip to content

Commit 11b1737

Browse files
authored
Merge pull request #727 from UWB-Biocomputing/master
Back merge of master into development to bring development completely up-to-date
2 parents d704de6 + b507ae9 commit 11b1737

26 files changed

+1220
-404
lines changed

.github/pull_request_template.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
<!-- Link to the issue and use the appropriate closing keyword (e.g., Closes, Resolves) -->
2+
Closes #
3+
4+
<!-- Please provide a brief overview of the changes implemented -->
5+
#### Description
6+
7+
8+
<!-- Please check the boxes as applicable -->
9+
#### Checklist (Mandatory for new features)
10+
- [ ] Added Documentation
11+
- [ ] Added Unit Tests
12+
13+
<!-- Ensure all boxes are checked before submitting the PR -->
14+
#### Testing (Mandatory for all changes)
15+
- [ ] GPU Test: `test-medium-connected.xml` Passed
16+
- [ ] GPU Test: `test-large-long.xml` Passed
17+
18+
<!--
19+
PR Guidelines
20+
1. Ensure that your changes are merged into the `development` branch. Only merge into the `master` branch if explicitly instructed.
21+
- On GitHub, at the top of the PR page, change the base branch from `master` to `development`.
22+
2. Assign the PR to yourself and apply the appropriate labels.
23+
3. Only add a reviewer after submitting the PR and confirming that all GitHub Actions have passed.
24+
25+
Thank you for your contribution!
26+
-->

.github/workflows/plantUML.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ jobs:
4343
run: |
4444
echo ${{ steps.getfile.outputs.files }}
4545
- name: Generate SVG Diagrams
46-
uses: cloudbees/plantuml-github-action@master
46+
uses: UWB-Biocomputing/plantuml-github-action@main
4747
with:
4848
args: -o "diagrams" -v -tsvg ${{ steps.getfile.outputs.files }}
4949
- name: Generate PNG Diagrams
50-
uses: cloudbees/plantuml-github-action@master
50+
uses: UWB-Biocomputing/plantuml-github-action@main
5151
with:
5252
args: -o "diagrams" -v -tpng ${{ steps.getfile.outputs.files }}
5353
- name: Push Local Changes

CMakeLists.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,16 @@ target_link_libraries(tests combinedLib)
402402
# # Link the combined library into the 'serialFileAccessTest' executable.
403403
# target_link_libraries(serialFileAccessTest combinedLib)
404404

405+
add_executable(serialFileAccessTest
406+
Testing/RunTests.cpp
407+
Testing/UnitTesting/SerializationFileAccessTest.cpp)
408+
409+
# Links the Googletest framework with the serialFileAccessTest executable
410+
target_link_libraries(serialFileAccessTest gtest gtest_main)
411+
412+
# Link the combined library into the 'serialFileAccessTest' executable.
413+
target_link_libraries(serialFileAccessTest combinedLib)
414+
405415
# Clear ENABLE_CUDA, PERFORMANCE_METRICS and GPROF from the cache so it's reset for subsequent builds
406416
unset(ENABLE_CUDA CACHE)
407417
unset(PERFORMANCE_METRICS CACHE)

Contributors.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ Natalie Gonzales
7272
## 2024
7373
Andrzej Dawiec
7474

75+
Jasleen Kaur Saini
76+
7577
ChengHao Hsu
7678

7779
Zaina Shaikh

Simulator/Layouts/NG911/Layout911.cpp

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,53 @@ void Layout911::registerGraphProperties()
2424
GraphManager &gm = GraphManager::getInstance();
2525
gm.registerProperty("objectID", &VertexProperty::objectID);
2626
gm.registerProperty("name", &VertexProperty::name);
27+
gm.registerProperty("type", &VertexProperty::type);
28+
gm.registerProperty("y", &VertexProperty::y);
29+
gm.registerProperty("x", &VertexProperty::x);
2730
gm.registerProperty("servers", &VertexProperty::servers);
2831
gm.registerProperty("trunks", &VertexProperty::trunks);
2932
gm.registerProperty("segments", &VertexProperty::segments);
3033
}
3134

35+
// Loads Layout911 member variables.
36+
void Layout911::loadParameters()
37+
{
38+
// Get the number of verticese from the GraphManager
39+
numVertices_ = GraphManager::getInstance().numVertices();
40+
}
41+
42+
// Setup the internal structure of the class.
43+
void Layout911::setup()
44+
{
45+
// Base class allocates memory for: xLoc_, yLoc, dist2_, and dist_
46+
// so we call its method first
47+
Layout::setup();
48+
49+
// Loop over all vertices and set their x and y locations
50+
GraphManager::VertexIterator vi, vi_end;
51+
GraphManager &gm = GraphManager::getInstance();
52+
for (boost::tie(vi, vi_end) = gm.vertices(); vi != vi_end; ++vi) {
53+
assert(*vi < numVertices_);
54+
xloc_[*vi] = gm[*vi].x;
55+
yloc_[*vi] = gm[*vi].y;
56+
}
57+
58+
// Now we cache the between each pair of vertices distances^2 into a matrix
59+
for (int n = 0; n < numVertices_ - 1; n++) {
60+
for (int n2 = n + 1; n2 < numVertices_; n2++) {
61+
// distance^2 between two points in point-slope form
62+
dist2_(n, n2) = (xloc_[n] - xloc_[n2]) * (xloc_[n] - xloc_[n2])
63+
+ (yloc_[n] - yloc_[n2]) * (yloc_[n] - yloc_[n2]);
64+
65+
// both points are equidistant from each other
66+
dist2_(n2, n) = dist2_(n, n2);
67+
}
68+
}
69+
70+
// Finally take the square root to get the distances
71+
dist_ = sqrt(dist2_);
72+
}
73+
3274
// Prints out all parameters to logging file.
3375
void Layout911::printParameters() const
3476
{

Simulator/Layouts/NG911/Layout911.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,14 @@ class Layout911 : public Layout {
5252
/// Register vertex properties with the GraphManager
5353
virtual void registerGraphProperties() override;
5454

55+
/// Loads Layout911 member variables.
56+
/// Registered to OperationManager as Operation::loadParameters
57+
virtual void loadParameters() override;
58+
59+
/// Setup the internal structure of the class.
60+
/// Allocate memories to store all layout state.
61+
virtual void setup() override;
62+
5563
/// Prints out all parameters to logging file.
5664
/// Registered to OperationManager as Operation::printParameters
5765
virtual void printParameters() const override;
-5.5 KB
Loading
-20.8 KB
Loading
234 KB
Loading
-2.61 KB
Loading

0 commit comments

Comments
 (0)