upgrade to grunt-contrib-jasmine 1.x (#2724)

* move to latest grunt-contrib-jasmine, adding a shim to declare globals now that phantomjs implements strict mode

* collapse the two jasmine spec helpers into one

* remove non-existent promise-polyfill.js test helper

* remove arraybuffer-slice dependency, no longer needed by phantomjs

* make all the test helpers and shims into vendor

Author: trevj

Gruntfile.js

@@ -890,7 +890,9 @@ module.exports = function(grunt) {
     },
     //-------------------------------------------------------------------------
     jasmine: {
-      chrome_extension: Rule.jasmineSpec('chrome/extension/scripts/', [path.join('build/src/mocks/chrome_mocks.js')])
+      chrome_core_connector: Rule.jasmineSpec('chrome/extension/scripts/chrome_core_connector', [
+        path.join('build/src/mocks/chrome_mocks.js')
+      ])
     },
     jasmine_chromeapp: {
       all: {
@@ -1177,7 +1179,7 @@ module.exports = function(grunt) {
   grunt.registerTask('test_chrome', [
     'build_chrome',
     'browserify:chromeExtensionCoreConnectorSpec',
-    'jasmine:chrome_extension'
+    'jasmine:chrome_core_connector'
   ]);
   grunt.registerTask('tcpIntegrationTestModule', [
     'base',

package.json

@@ -21,7 +21,6 @@
     }
   ],
   "devDependencies": {
-    "arraybuffer-slice": "^0.1.2",
     "bower": "^1.4.1",
     "browserify-zlib": "^0.1.4",
     "cca": "^0.8.0",
@@ -47,7 +46,7 @@
     "grunt-cli": "^0.1.13",
     "grunt-contrib-clean": "^0.6.0",
     "grunt-contrib-copy": "^0.8.0",
-    "grunt-contrib-jasmine": "^0.9.0",
+    "grunt-contrib-jasmine": "^1.0.3",
     "grunt-contrib-jshint": "^1.0.0",
     "grunt-contrib-symlink": "^0.3.0",
     "grunt-contrib-watch": "^1.0.0",

src/lib/build-tools/common-grunt-rules.ts

@@ -17,8 +17,9 @@ export interface RuleConfig {
 }
 
 export interface JasmineRule {
-  src :string[];
+  src ?:string[];
   options ?:{
+    vendor ?:string|string[];
     specs :string[];
     outfile ?:string;
     keepRunner ?:boolean;
@@ -78,39 +79,27 @@ export class Rule {
     return spec;
   }
 
-  // Grunt Jasmine target creator
-  // Assumes that the each spec file is a fully browserified js file.
+  // grunt-contrib-jasmine target creator. Assumes that the spec
+  // is browserified, i.e. has a .spec.static.js suffix.
   public jasmineSpec(name:string, morefiles?:string[]) :JasmineRule {
     if (!morefiles) { morefiles = []; }
     return {
-      src: [
-        require.resolve('arraybuffer-slice'),
-        require.resolve('es6-promise'),
-        path.join(this.config.thirdPartyBuildPath, 'promise-polyfill.js'),
-      ].concat(morefiles),
       options: {
-        specs: [ path.join(this.config.devBuildPath, name, '/**/*.spec.static.js') ],
+        vendor: [
+          // phantomjs does not yet understand Promises natively:
+          //   https://github.com/ariya/phantomjs/issues/14166
+          require.resolve('es6-promise'),
+          // Declares globals, notably freedom, without which test
+          // environments implementing strict mode will fail.
+          './src/lib/build-tools/testing/globals.js'
+        ].concat(morefiles),
+        specs: [ path.join(this.config.devBuildPath, name + '.spec.static.js') ],
         outfile: path.join(this.config.devBuildPath, name, '/SpecRunner.html'),
         keepRunner: true
       }
     }
   }
 
-  public jasmineSingleSpec(file :string) :JasmineRule {
-    return {
-      src: [
-        require.resolve('arraybuffer-slice'),
-        require.resolve('es6-promise'),
-        path.join(this.config.thirdPartyBuildPath, 'promise-polyfill.js'),
-      ],
-      options: {
-        specs: [ path.join(this.config.devBuildPath, file + '.spec.static.js') ],
-        outfile: path.join(this.config.devBuildPath, file, '/SpecRunner.html'),
-        keepRunner: true
-      }
-    }
-  }
-
   // Grunt browserify target creator
   public browserify(filepath:string, options = {
     browserifyOptions: {
@@ -253,7 +242,7 @@ export class Rule {
   public buildAndRunTest(test :string, grunt :any, coverage?:boolean) :string[] {
     var name = test + 'Spec';
     var browserifyRule = this.browserifySpec(test);
-    var jasmineRule = this.jasmineSingleSpec(test);
+    var jasmineRule = this.jasmineSpec(test);
 
     if (coverage) {
       name += 'Cov';

src/lib/build-tools/testing/globals.js

@@ -0,0 +1,10 @@
+// Include this file to avoid ECMAScript 5 strict mode errors
+// related to creation of global objects, in particular freedom.js
+// in unit tests - while neither the Chrome nor Firefox extension
+// environments implement strict mode, recent versions of phantomjs
+// (used by jasmine), do as of course do Chrome and Firefox when
+// loading and debugging the SpecRunner manually.
+
+// There are a bunch of helpers under src/freedom/mocks which can
+// inject behaviour into this object.
+var freedom = {};