test_open_dataset_with_fallback that failed on Windows with a PermissionError. The temporary file was still open during deletion

Author: rajeeja

test/core/test_api.py

@@ -6,6 +6,7 @@
 import xarray as xr
 from unittest.mock import patch
 from uxarray.core.utils import _open_dataset_with_fallback
+import os
 
 def test_open_geoflow_dataset(gridpath, datasetpath):
     """Loads a single dataset with its grid topology file using uxarray's
@@ -121,13 +122,16 @@ def test_open_dataset_grid_kwargs(gridpath, datasetpath):
 def test_open_dataset_with_fallback():
     """Test that the fallback mechanism works when the default engine fails."""
 
-    # Create a simple test dataset
-    with tempfile.NamedTemporaryFile(suffix='.nc', delete=False) as tmp:
-        data = xr.Dataset({'temp': (['x', 'y'], np.random.rand(5, 5))})
-        data.to_netcdf(tmp.name)
-        tmp_path = tmp.name
-
+    tmp_path = ""
+    ds = None
+    ds_fallback = None
     try:
+        # Create a simple test dataset
+        with tempfile.NamedTemporaryFile(suffix='.nc', delete=False) as tmp:
+            data = xr.Dataset({'temp': (['x', 'y'], np.random.rand(5, 5))})
+            data.to_netcdf(tmp.name)
+            tmp_path = tmp.name
+
         # Test normal case
         ds = _open_dataset_with_fallback(tmp_path)
         assert isinstance(ds, xr.Dataset)
@@ -149,5 +153,9 @@ def mock_open_dataset(*args, **kwargs):
             assert call_count == 2  # First failed, second succeeded
 
     finally:
-        import os
-        os.unlink(tmp_path)
+        if ds is not None:
+            ds.close()
+        if ds_fallback is not None:
+            ds_fallback.close()
+        if os.path.exists(tmp_path):
+            os.unlink(tmp_path)