Apply review changes: add final to selected exception classes

Author: sebaciv

auth/.js/src/main/scala/io/udash/auth/AuthApplication.scala

@@ -4,7 +4,7 @@ import io.udash._
 
 object AuthApplication {
   implicit final class ApplicationAuthExt[HierarchyRoot >: Null <: GState[HierarchyRoot]](
-    val application: Application[HierarchyRoot]
+    private val application: Application[HierarchyRoot]
   ) extends AnyVal {
     /**
       * Adds the default listener of authorization failure in routing (redirects to provided state).

auth/src/main/scala/io/udash/auth/exceptions.scala

@@ -1,13 +1,5 @@
 package io.udash.auth
 
-import com.avsystem.commons.serialization.HasGenCodec
+class UnauthenticatedException extends RuntimeException(s"User has to be authenticated to access this content.")
 
-import scala.annotation.nowarn
-
-@nowarn("msg=Case classes should be marked as final")
-case class UnauthenticatedException() extends RuntimeException(s"User has to be authenticated to access this content.")
-object UnauthenticatedException extends HasGenCodec[UnauthenticatedException]
-
-@nowarn("msg=Case classes should be marked as final")
-case class UnauthorizedException() extends RuntimeException(s"Provided user context does not have access to this content.")
-object UnauthorizedException extends HasGenCodec[UnauthorizedException]
+class UnauthorizedException extends RuntimeException(s"Provided user context does not have access to this content.")

rest/src/main/scala/io/udash/rest/raw/RestRequest.scala

@@ -6,7 +6,6 @@ import com.avsystem.commons.meta.*
 import com.avsystem.commons.misc.{AbstractValueEnum, AbstractValueEnumCompanion, EnumCtx}
 import com.avsystem.commons.rpc.*
 
-import scala.annotation.nowarn
 import scala.util.control.NoStackTrace
 
 /**
@@ -24,14 +23,14 @@ final case class RestParameters(
   @multi @tagged[Path] path: List[PlainValue] = Nil,
   @multi @tagged[Header] @allowOptional headers: IMapping[PlainValue] = IMapping.empty,
   @multi @tagged[Query] @allowOptional query: Mapping[PlainValue] = Mapping.empty,
-  @multi @tagged[Cookie] @allowOptional cookies: Mapping[PlainValue] = Mapping.empty
+  @multi @tagged[Cookie] @allowOptional cookies: Mapping[PlainValue] = Mapping.empty,
 ) {
   def append(method: RestMethodMetadata[_], otherParameters: RestParameters): RestParameters =
     RestParameters(
       path ::: method.applyPathParams(otherParameters.path),
       headers ++ otherParameters.headers,
       query ++ otherParameters.query,
-      cookies ++ otherParameters.cookies
+      cookies ++ otherParameters.cookies,
     )
 
   def path(values: String*): RestParameters =
@@ -50,8 +49,7 @@ object RestParameters {
   final val Empty = RestParameters()
 }
 
-@nowarn("msg=Case classes should be marked as final")
-case class HttpErrorException(code: Int, payload: HttpBody = HttpBody.Empty, cause: Throwable = null)
+final case class HttpErrorException(code: Int, payload: HttpBody = HttpBody.Empty, cause: Throwable = null)
   extends RuntimeException(s"HTTP ERROR $code${payload.textualContentOpt.fold("")(p => s": $p")}", cause) with NoStackTrace {
   def toResponse: RestResponse = RestResponse(code, IMapping.empty, payload)
 }

rpc/.js/src/main/scala/io/udash/rpc/internals/UsesServerRPC.scala

@@ -5,7 +5,6 @@ import io.udash.rpc.*
 import io.udash.utils.{CallbacksHandler, Registration}
 import org.scalajs.dom
 
-import scala.annotation.nowarn
 import scala.concurrent.duration.{Duration, DurationInt}
 import scala.concurrent.{Future, Promise}
 import scala.scalajs.js
@@ -97,6 +96,5 @@ private[rpc] trait UsesServerRPC[ServerRPCType] extends UsesRemoteRPC[ServerRPCT
 }
 
 object UsesServerRPC {
-  @nowarn("msg=Case classes should be marked as final")
-  case class CallTimeout(callTimeout: Duration) extends RuntimeException(s"Response missing after $callTimeout.")
+  final case class CallTimeout(callTimeout: Duration) extends RuntimeException(s"Response missing after $callTimeout.")
 }