Skip to content

Commit 3b5972c

Browse files
committed
Remove deprecated API usage
1 parent fa3a882 commit 3b5972c

File tree

3 files changed

+22
-24
lines changed

3 files changed

+22
-24
lines changed

guide/selenium/src/test/scala/io/udash/web/guide/demos/frontend/FrontendFormsTest.scala

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
package io.udash.web.guide.demos.frontend
22

3+
import com.avsystem.commons.*
34
import io.udash.web.SeleniumTest
45
import org.openqa.selenium.By.{ByClassName, ByCssSelector, ByTagName}
5-
import org.openqa.selenium.{By, Keys}
66

7-
import com.avsystem.commons._
87
import scala.util.Random
98

109
class FrontendFormsTest extends SeleniumTest {
@@ -23,7 +22,7 @@ class FrontendFormsTest extends SeleniumTest {
2322
el.getText == expect
2423
}) should be(true)
2524
checkboxes.findElements(new ByClassName(s"checkbox-demo-$propertyName")).asScala.forall(el => {
26-
el.getAttribute("selected") == checkbox.getAttribute("selected")
25+
el.getDomAttribute("selected") == checkbox.getDomAttribute("selected")
2726
}) should be(true)
2827
}
2928
}
@@ -47,10 +46,10 @@ class FrontendFormsTest extends SeleniumTest {
4746
eventually {
4847
checkButtons.findElements(new ByClassName("check-buttons-demo-fruits")).asScala.forall(el => {
4948
val contains = el.getText.contains(propertyName)
50-
if (checkbox.getAttribute("selected") != null) contains else !contains
49+
if (checkbox.getDomAttribute("selected") != null) contains else !contains
5150
}) should be(true)
5251
checkButtons.findElements(new ByCssSelector(s"[data-label=$propertyName]")).asScala.forall(el => {
53-
el.findElement(new ByTagName("input")).getAttribute("selected") == checkbox.getAttribute("selected")
52+
el.findElement(new ByTagName("input")).getDomAttribute("selected") == checkbox.getDomAttribute("selected")
5453
}) should be(true)
5554
}
5655
}
@@ -70,10 +69,10 @@ class FrontendFormsTest extends SeleniumTest {
7069
eventually {
7170
multiSelect.findElements(new ByClassName("multi-select-demo-fruits")).asScala.forall(el => {
7271
val contains = el.getText.contains(propertyName)
73-
if (option.getAttribute("selected") != null) contains else !contains
72+
if (option.getDomAttribute("selected") != null) contains else !contains
7473
}) should be(true)
7574
multiSelect.findElements(new ByTagName("select")).asScala.forall(el => {
76-
el.findElement(new ByCssSelector(s"[value='$propertyIdx']")).getAttribute("selected") == option.getAttribute("selected")
75+
el.findElement(new ByCssSelector(s"[value='$propertyIdx']")).getDomAttribute("selected") == option.getDomAttribute("selected")
7776
}) should be(true)
7877
}
7978
}
@@ -96,8 +95,8 @@ class FrontendFormsTest extends SeleniumTest {
9695
el.getText == propertyName
9796
}) should be(true)
9897
radioButtons.findElements(new ByCssSelector(s"input")).asScala.forall(el => {
99-
val eq = el.getAttribute("selected") == radio.getAttribute("selected")
100-
if (el.getAttribute("value").toInt == propertyIdx) eq else !eq
98+
val eq = el.getDomAttribute("selected") == radio.getDomAttribute("selected")
99+
if (el.getDomAttribute("value").toInt == propertyIdx) eq else !eq
101100
}) should be(true)
102101
}
103102
}
@@ -121,7 +120,7 @@ class FrontendFormsTest extends SeleniumTest {
121120
el.getText == propertyName
122121
}) should be(true)
123122
selectDemo.findElements(new ByTagName(s"select")).asScala.forall(el => {
124-
el.findElement(new ByCssSelector(s"[value='$propertyIdx']")).getAttribute("selected") == option.getAttribute("selected")
123+
el.findElement(new ByCssSelector(s"[value='$propertyIdx']")).getDomAttribute("selected") == option.getDomAttribute("selected")
125124
}) should be(true)
126125
}
127126
}
@@ -142,7 +141,7 @@ class FrontendFormsTest extends SeleniumTest {
142141
textArea.sendKeys(text)
143142
eventually {
144143
textAreaDemo.findElements(new ByTagName(s"textarea")).asScala.forall(el => {
145-
el.getAttribute("value") == text
144+
el.getDomAttribute("value") == text
146145
}) should be(true)
147146
}
148147
}
@@ -161,7 +160,7 @@ class FrontendFormsTest extends SeleniumTest {
161160
input.sendKeys(text)
162161
eventually {
163162
inputsDemo.findElements(new ByCssSelector(s"input[type=$tpe]")).asScala.forall(el => {
164-
el.getAttribute("value") == text
163+
el.getDomAttribute("value") == text
165164
}) should be(true)
166165
}
167166
}

guide/selenium/src/test/scala/io/udash/web/guide/demos/frontend/FrontendIntroTest.scala

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,21 +80,21 @@ class FrontendIntroTest extends SeleniumTest {
8080
val between = demo.findElement(new ById("between"))
8181
val maximum = demo.findElement(new ById("maximum"))
8282

83-
var lastMinimum = minimum.getAttribute("value")
84-
var lastBetween = between.getAttribute("value")
85-
var lastMaximum = maximum.getAttribute("value")
83+
var lastMinimum = minimum.getDomAttribute("value")
84+
var lastBetween = between.getDomAttribute("value")
85+
var lastMaximum = maximum.getDomAttribute("value")
8686

8787
for (_ <- 1 to 5) {
8888
randomizeButton.click()
8989
eventually {
90-
(lastMinimum != minimum.getAttribute("value") ||
91-
lastBetween != between.getAttribute("value") ||
92-
lastMaximum != maximum.getAttribute("value")) should be(true)
90+
(lastMinimum != minimum.getDomAttribute("value") ||
91+
lastBetween != between.getDomAttribute("value") ||
92+
lastMaximum != maximum.getDomAttribute("value")) should be(true)
9393
}
9494

95-
lastMinimum = minimum.getAttribute("value")
96-
lastBetween = between.getAttribute("value")
97-
lastMaximum = maximum.getAttribute("value")
95+
lastMinimum = minimum.getDomAttribute("value")
96+
lastBetween = between.getDomAttribute("value")
97+
lastMaximum = maximum.getDomAttribute("value")
9898
}
9999
}
100100
}

guide/selenium/src/test/scala/io/udash/web/guide/demos/frontend/FrontendRoutingTest.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package io.udash.web.guide.demos.frontend
22

33
import io.udash.web.SeleniumTest
4-
import org.openqa.selenium.By
54

65
class FrontendRoutingTest extends SeleniumTest {
76
override protected final val url = "/frontend/routing"
@@ -51,7 +50,7 @@ class FrontendRoutingTest extends SeleniumTest {
5150
link.getText should be("/frontend/routing/pizza")
5251
}
5352

54-
input.getAttribute("value") should be("It should not disappear... Selenium")
53+
input.getDomAttribute("value") should be("It should not disappear... Selenium")
5554
}
5655

5756
"change URL basing on input without view redraw" in {
@@ -81,7 +80,7 @@ class FrontendRoutingTest extends SeleniumTest {
8180
}
8281

8382
init.getText should be("/frontend/routing")
84-
input.getAttribute("value") should be("It should not disappear... Selenium")
83+
input.getDomAttribute("value") should be("It should not disappear... Selenium")
8584
}
8685
}
8786
}

0 commit comments

Comments
 (0)