Fix selection checks

Author: ddworak

guide/selenium/src/test/scala/io/udash/web/SeleniumTest.scala

@@ -1,14 +1,15 @@
 package io.udash.web
 
+import com.typesafe.scalalogging.StrictLogging
 import io.github.bonigarcia.wdm.WebDriverManager
 import org.openqa.selenium.firefox.{FirefoxDriver, FirefoxOptions}
 import org.openqa.selenium.remote.RemoteWebDriver
 import org.openqa.selenium.{By, Dimension, WebElement}
 import org.scalatest.concurrent.Eventually
-import org.scalatest.time.{Millis, Seconds, Span}
-import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
 import org.scalatest.matchers.should.Matchers
+import org.scalatest.time.{Millis, Seconds, Span}
 import org.scalatest.wordspec.AnyWordSpec
+import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach, Inspectors}
 
 import java.time.Duration
 
@@ -41,13 +42,15 @@ private final class InternalServerConfig extends ServerConfig {
 
   override def createUrl(part: String): String = {
     require(part.startsWith("/"))
-    s"http://127.0.0.2:${server.port}$part"
+    s"http://localhost:${server.port}$part"
   }
 }
 
-abstract class SeleniumTest extends AnyWordSpec with Matchers with BeforeAndAfterAll with BeforeAndAfterEach with Eventually {
+abstract class SeleniumTest extends AnyWordSpec
+  with Matchers with BeforeAndAfterAll with BeforeAndAfterEach with Eventually with StrictLogging with Inspectors {
   override implicit val patienceConfig: PatienceConfig = PatienceConfig(scaled(Span(10, Seconds)), scaled(Span(50, Millis)))
 
+  logger.info("Setting up WebDriver")
   private val driverManager = WebDriverManager.firefoxdriver()
   driverManager.config().setServerPort(0)
   driverManager.setup()

guide/selenium/src/test/scala/io/udash/web/guide/demos/frontend/FrontendFormsTest.scala

@@ -1,6 +1,5 @@
 package io.udash.web.guide.demos.frontend
 
-import com.avsystem.commons.*
 import io.udash.web.SeleniumTest
 import org.openqa.selenium.By.{ByClassName, ByCssSelector, ByTagName}
 
@@ -18,12 +17,12 @@ class FrontendFormsTest extends SeleniumTest {
         val checkbox = checkboxes.findElement(new ByClassName(s"checkbox-demo-$propertyName"))
         checkbox.click()
         eventually {
-          checkboxes.findElements(new ByCssSelector(s"[data-bind=$propertyName]")).asScala.forall(el => {
-            el.getText == expect
-          }) should be(true)
-          checkboxes.findElements(new ByClassName(s"checkbox-demo-$propertyName")).asScala.forall(el => {
-            el.getDomAttribute("selected") == checkbox.getDomAttribute("selected")
-          }) should be(true)
+          forAll(checkboxes.findElements(new ByCssSelector(s"[data-bind=$propertyName]")))(el =>
+            el.getText shouldBe expect
+          )
+          forAll(checkboxes.findElements(new ByClassName(s"checkbox-demo-$propertyName")))(el =>
+            el.isSelected shouldBe checkbox.isSelected
+          )
         }
       }
 
@@ -44,13 +43,13 @@ class FrontendFormsTest extends SeleniumTest {
         val checkbox = checkButtons.findElement(new ByCssSelector(s"[data-label=$propertyName]")).findElement(new ByTagName("input"))
         checkbox.click()
         eventually {
-          checkButtons.findElements(new ByClassName("check-buttons-demo-fruits")).asScala.forall(el => {
+          forAll(checkButtons.findElements(new ByClassName("check-buttons-demo-fruits")))(el => {
             val contains = el.getText.contains(propertyName)
-            if (checkbox.getDomAttribute("selected") != null) contains else !contains
-          }) should be(true)
-          checkButtons.findElements(new ByCssSelector(s"[data-label=$propertyName]")).asScala.forall(el => {
-            el.findElement(new ByTagName("input")).getDomAttribute("selected") == checkbox.getDomAttribute("selected")
-          }) should be(true)
+            assert(if (checkbox.isSelected) contains else !contains)
+          })
+          forAll(checkButtons.findElements(new ByCssSelector(s"[data-label=$propertyName]")))(el =>
+            el.findElement(new ByTagName("input")).isSelected shouldBe checkbox.isSelected
+          )
         }
       }
 
@@ -67,13 +66,13 @@ class FrontendFormsTest extends SeleniumTest {
         val option = select.findElement(new ByCssSelector(s"[value='$propertyIdx']"))
         option.click()
         eventually {
-          multiSelect.findElements(new ByClassName("multi-select-demo-fruits")).asScala.forall(el => {
+          forAll(multiSelect.findElements(new ByClassName("multi-select-demo-fruits")))(el => {
             val contains = el.getText.contains(propertyName)
-            if (option.getDomAttribute("selected") != null) contains else !contains
-          }) should be(true)
-          multiSelect.findElements(new ByTagName("select")).asScala.forall(el => {
-            el.findElement(new ByCssSelector(s"[value='$propertyIdx']")).getDomAttribute("selected") == option.getDomAttribute("selected")
-          }) should be(true)
+            assert(if (option.isSelected) contains else !contains)
+          })
+          forAll(multiSelect.findElements(new ByTagName("select")))(el => {
+            el.findElement(new ByCssSelector(s"[value='$propertyIdx']")).isSelected shouldBe option.isSelected
+          })
         }
       }
 
@@ -91,13 +90,13 @@ class FrontendFormsTest extends SeleniumTest {
         val radio = radioButtons.findElement(new ByCssSelector(s"[data-label=$propertyName]")).findElement(new ByTagName("input"))
         driver.executeScript("arguments[0].click();", radio)
         eventually {
-          radioButtons.findElements(new ByClassName("radio-buttons-demo-fruits")).asScala.forall(el => {
-            el.getText == propertyName
-          }) should be(true)
-          radioButtons.findElements(new ByCssSelector(s"input")).asScala.forall(el => {
-            val eq = el.getDomAttribute("selected") == radio.getDomAttribute("selected")
-            if (el.getDomProperty("value").toInt == propertyIdx) eq else !eq
-          }) should be(true)
+          forAll(radioButtons.findElements(new ByClassName("radio-buttons-demo-fruits")))(el =>
+            el.getText shouldBe propertyName
+          )
+          forAll(radioButtons.findElements(new ByCssSelector(s"input")))(el => {
+            val eq = el.isSelected == radio.isSelected
+            assert(if (el.getDomProperty("value").toInt == propertyIdx) eq else !eq)
+          })
         }
       }
 
@@ -116,12 +115,12 @@ class FrontendFormsTest extends SeleniumTest {
         val option = select.findElement(new ByCssSelector(s"[value='$propertyIdx']"))
         option.click()
         eventually {
-          selectDemo.findElements(new ByClassName("select-demo-fruits")).asScala.forall(el => {
-            el.getText == propertyName
-          }) should be(true)
-          selectDemo.findElements(new ByTagName(s"select")).asScala.forall(el => {
-            el.findElement(new ByCssSelector(s"[value='$propertyIdx']")).getDomAttribute("selected") == option.getDomAttribute("selected")
-          }) should be(true)
+          forAll(selectDemo.findElements(new ByClassName("select-demo-fruits")))(el => {
+            el.getText shouldBe propertyName
+          })
+          forAll(selectDemo.findElements(new ByTagName(s"select")))(el => {
+            el.findElement(new ByCssSelector(s"[value='$propertyIdx']")).isSelected shouldBe option.isSelected
+          })
         }
       }
 
@@ -140,9 +139,9 @@ class FrontendFormsTest extends SeleniumTest {
         textArea.clear()
         textArea.sendKeys(text)
         eventually {
-          textAreaDemo.findElements(new ByTagName(s"textarea")).asScala.forall(el => {
-            el.getDomProperty("value") == text
-          }) should be(true)
+          forAll(textAreaDemo.findElements(new ByTagName(s"textarea")))(el => {
+            el.getDomProperty("value") shouldBe text
+          })
         }
       }
 
@@ -159,9 +158,9 @@ class FrontendFormsTest extends SeleniumTest {
         input.clear()
         input.sendKeys(text)
         eventually {
-          inputsDemo.findElements(new ByCssSelector(s"input[type=$tpe]")).asScala.forall(el => {
-            el.getDomProperty("value") == text
-          }) should be(true)
+          forAll(inputsDemo.findElements(new ByCssSelector(s"input[type=$tpe]")))(el => {
+            el.getDomProperty("value") shouldBe text
+          })
         }
       }