Skip to content

Commit 04d9320

Browse files
authored
Merge pull request #127 from UgnisSoftware/UGN-361
chore UGN-361 - update docs and set parseRaw: true as default
2 parents 1b479ca + 64b5685 commit 04d9320

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,9 +181,10 @@ import { ReactSpreadsheetImport, StepType } from "react-spreadsheet-import";
181181
### Dates and time
182182

183183
Excel stores dates and times as numbers - offsets from an epoch. When reading xlsx files SheetJS provides date formatting helpers.
184-
**Default date import format** is `yyyy-mm-dd`. This format can be changed using **dateFormat** property.
184+
**Default date import format** is `yyyy-mm-dd`. Date parsing with SheetJS sometimes yields unexpected results, therefore thorough date validations are recommended.
185185

186-
- **dateFormat** - can be used to format dates when importing sheet data.
186+
- **dateFormat** - sets SheetJS `dateNF` option. Can be used to format dates when importing sheet data.
187+
- **parseRaw** - sets SheetJS `raw` option. If `true`, date formatting will be applied to XLSX date fields only. Default is `true`
187188

188189
Common date-time formats can be viewed [here](https://docs.sheetjs.com/docs/csf/features/dates/#date-and-time-number-formats).
189190

src/ReactSpreadsheetImport.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export const defaultRSIProps: Partial<RsiProps<any>> = {
1818
selectHeaderStepHook: async (headerValues, data) => ({ headerValues, data }),
1919
matchColumnsStepHook: async (table) => table,
2020
dateFormat: "yyyy-mm-dd", // ISO 8601,
21-
parseRaw: false,
21+
parseRaw: true,
2222
} as const
2323

2424
export const ReactSpreadsheetImport = <T extends string>(props: RsiProps<T>) => {

src/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ export type RsiProps<T extends string> = {
3939
autoMapDistance?: number
4040
// Initial Step state to be rendered on load
4141
initialStepState?: StepState
42-
// Date format to use e.g. "yyyy-mm-dd hh:mm:ss", "m/d/yy h:mm", 'mmm-yy', etc.
42+
// Sets SheetJS dateNF option. If date parsing is applied, date will be formatted e.g. "yyyy-mm-dd hh:mm:ss", "m/d/yy h:mm", 'mmm-yy', etc.
4343
dateFormat?: string
44-
//Skips parsing of values e.g. date
44+
// Sets SheetJS "raw" option. If true, parsing will only be applied to xlsx date fields.
4545
parseRaw?: boolean
4646
}
4747

0 commit comments

Comments
 (0)