Skip to content

Commit 6504a7f

Browse files
authored
Merge pull request #82 from UiPath/fix/docs_binary
fix: set proper span status
2 parents dd3393a + 5c089ff commit 6504a7f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

samples/github-helper-agent/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ The agent consists of three main components:
1818

1919
The agent responds to the following commands:
2020

21-
- Reviewer: `/help suggest`, `/help review`, `/help test`
21+
- Reviewer: `/help summarize`, `/help suggest`, `/help review`, `/help test`
2222
- Developer: `/help commit` (commits the latest suggestion/review/tests)
2323

2424
## Architecture

src/uipath_mcp/_cli/_runtime/_tracer.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ def create_span_for_message(self, message: types.JSONRPCMessage, **context) -> S
6262
span.set_attribute("span_type", "MCP error")
6363
span.set_attribute("id", str(root_value.id))
6464
span.set_attribute("error_code", root_value.error.code)
65-
span.set_attribute("error_message", root_value.error.message)
65+
span.set_attribute("error", root_value.error.message)
66+
span.set_status(StatusCode.ERROR)
67+
6668

6769
# Remove the request from active tracking
6870
self._active_request_spans.pop(request_id, None)
@@ -99,7 +101,8 @@ def create_span_for_message(self, message: types.JSONRPCMessage, **context) -> S
99101
span.set_attribute("span_type", "MCP error")
100102
span.set_attribute("id", str(root_value.id))
101103
span.set_attribute("error_code", root_value.error.code)
102-
span.set_attribute("error_message", root_value.error.message)
104+
span.set_attribute("error", root_value.error.message)
105+
span.set_status(StatusCode.ERROR)
103106
else:
104107
span = self._tracer.start_span("unknown")
105108
span.set_attribute("span_type", str(type(root_value).__name__))

0 commit comments

Comments
 (0)