Skip to content

Commit 3513ce7

Browse files
authored
feat: Ada 3.2.7 (NativeScript#1835)
1 parent 83f611b commit 3513ce7

File tree

3 files changed

+3103
-2769
lines changed

3 files changed

+3103
-2769
lines changed

test-app/runtime/src/main/cpp/URLPatternImpl.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ v8_regex_provider::regex_search(std::string_view input,
7171
ret.reserve(len);
7272
for (int i = 0; i < len; i++) {
7373
v8::Local<v8::Value> item;
74-
if (array->Get(isolate->GetCurrentContext(), i).ToLocal(&item)) {
74+
if (!array->Get(isolate->GetCurrentContext(), i).ToLocal(&item)) {
7575
return std::nullopt;
7676
}
7777

@@ -354,7 +354,7 @@ void URLPatternImpl::Ctor(const v8::FunctionCallbackInfo<v8::Value> &args) {
354354
if(args.Length() == 0){
355355
auto thiz = args.This();
356356
auto init = ada::url_pattern_init{};
357-
auto url_pattern = ada::parse_url_pattern<v8_regex_provider>(init);
357+
auto url_pattern = ada::parse_url_pattern<v8_regex_provider>(std::move(init));
358358
if (!url_pattern) {
359359
isolate->ThrowException(
360360
v8::Exception::TypeError(
@@ -447,7 +447,7 @@ void URLPatternImpl::Ctor(const v8::FunctionCallbackInfo<v8::Value> &args) {
447447
}
448448

449449
auto url_pattern = ada::parse_url_pattern<v8_regex_provider>(
450-
arg0,
450+
std::move(arg0),
451451
base_url.has_value() ? &base_url_view : nullptr,
452452
options.has_value() ? &options.value() : nullptr);
453453
if (!url_pattern) {

0 commit comments

Comments
 (0)