fix: move $instance creation before /stream route to fix non-static permission callback (#513)

check_chat_permission() is a non-static instance method but was being
called statically via [__CLASS__, 'check_chat_permission'], causing a
fatal TypeError on every chat request.

Move $instance = new self() before the /stream route registration and
use [$instance, 'check_chat_permission'] for the permission_callback.
The /run route reuses the same $instance (no duplicate instantiation).

Closes #509

Author: superdav42

includes/REST/RestController.php

@@ -90,13 +90,14 @@ public static function register_routes(): void {
 		// Resale API endpoints.
 		ResaleApiController::register_routes();
 
+		$instance = new self();
 		register_rest_route(
 			self::NAMESPACE,
 			'/stream',
 			[
 				'methods'             => WP_REST_Server::CREATABLE,
 				'callback'            => [ __CLASS__, 'handle_stream' ],
-				'permission_callback' => [ __CLASS__, 'check_chat_permission' ],
+				'permission_callback' => [ $instance, 'check_chat_permission' ],
 				'args'                => [
 					'message'            => [
 						'required'          => true,
@@ -149,7 +150,6 @@ public static function register_routes(): void {
 			]
 		);
 
-		$instance = new self();
 		register_rest_route(
 			self::NAMESPACE,
 			'/run',