attempt fix

Author: cvanelteren

ultraplot/colors.py

@@ -23,8 +23,8 @@
 from numbers import Integral, Number
 from xml.etree import ElementTree
 
-import matplotlib.cm as mcm
 import matplotlib as mpl
+import matplotlib.cm as mcm
 import matplotlib.colors as mcolors
 import numpy as np
 import numpy.ma as ma
@@ -44,12 +44,12 @@ def _cycle_handler(value):
 
 rc.register_handler("cycle", _cycle_handler)
 
-from .internals import ic  # noqa: F401
 from .internals import (
     _kwargs_to_args,
     _not_none,
     _pop_props,
     docstring,
+    ic,  # noqa: F401
     inputs,
     warnings,
 )
@@ -910,11 +910,12 @@ def _warn_or_raise(descrip, error=RuntimeError):
             # NOTE: This appears to be biggest import time bottleneck! Increases
             # time from 0.05s to 0.2s, with numpy loadtxt or with this regex thing.
             delim = re.compile(r"[,\s]+")
-            data = [
-                delim.split(line.strip())
-                for line in open(path)
-                if line.strip() and line.strip()[0] != "#"
-            ]
+            with open(path) as f:
+                data = [
+                    delim.split(line.strip())
+                    for line in f
+                    if line.strip() and line.strip()[0] != "#"
+                ]
             try:
                 data = [[float(num) for num in line] for line in data]
             except ValueError:
@@ -966,7 +967,8 @@ def _warn_or_raise(descrip, error=RuntimeError):
         # Read hex strings
         elif ext == "hex":
             # Read arbitrary format
-            string = open(path).read()  # into single string
+            with open(path) as f:
+                string = f.read()  # into single string
             data = REGEX_HEX_MULTI.findall(string)
             if len(data) < 2:
                 return _warn_or_raise("Failed to find 6-digit or 8-digit HEX strings.")

ultraplot/ui.py

@@ -226,7 +226,7 @@ def subplots(*args, **kwargs):
     _parse_figsize(kwargs)
     rc_kw, rc_mode = _pop_rc(kwargs)
     kwsubs = _pop_props(kwargs, "patch")  # e.g. 'color'
-    kwsubs.update(_pop_params(kwargs, pfigure._add_subplots))
+    kwsubs.update(_pop_params(kwargs, pfigure.Figure._add_subplots))
     kwsubs.update(_pop_params(kwargs, pgridspec.GridSpec._update_params))
     for sig in paxes.Axes._format_signatures.values():
         kwsubs.update(_pop_params(kwargs, sig))