CAN Analog cast to int16 for correct sign

Ultrawipf · Ultrawipf · commit f4f6b92ee1b7 · 2025-05-02T11:59:30.000+02:00
diff --git a/Firmware/FFBoard/UserExtensions/Src/CanAnalog.cpp b/Firmware/FFBoard/UserExtensions/Src/CanAnalog.cpp
@@ -117,7 +117,7 @@ void CanAnalogBase::canRxPendCallback(CANPort* port,CAN_rx_msg& msg){
 			continue;
 		}
 		for(uint8_t i = 0; i < 4 && (i + packet*4) < axes && (i*2+1) < msg.header.length; i++) {
-			this->buf[i + packet*4] = msg.data[i*2] | (msg.data[i*2+1] << 8);
+			this->buf[i + packet*4] = (int16_t)(msg.data[i*2] | (msg.data[i*2+1] << 8));
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ void CanAnalogBase::canRxPendCallback(CANPort* port,CAN_rx_msg& msg){`
`117`	`117`	`continue;`
`118`	`118`	`}`
`119`	`119`	`for(uint8_t i = 0; i < 4 && (i + packet4) < axes && (i2+1) < msg.header.length; i++) {`
`120`		`- this->buf[i + packet4] = msg.data[i2] \| (msg.data[i*2+1] << 8);`
	`120`	`+ this->buf[i + packet4] = (int16_t)(msg.data[i2] \| (msg.data[i*2+1] << 8));`
`121`	`121`	`}`
`122`	`122`	`}`
`123`	`123`	`}`