🤖 Merge PR DefinitelyTyped#73979 fix(chrome): Fix definitions of MV2 permissions by @rnwst

Author: rnwst

types/chrome/index.d.ts

@@ -246,7 +246,7 @@ declare namespace chrome {
         ): void;
 
         /**
-         * Gets the badge text of the action. If no tab is specified, the non-tab-specific badge text is returned. If {@link declarativeNetRequest.ExtensionActionOptions.displayActionCountAsBadgeText displayActionCountAsBadgeText} is enabled, a placeholder text will be returned unless the {@link runtime.ManifestPermissions declarativeNetRequestFeedback} permission is present or tab-specific badge text was provided.
+         * Gets the badge text of the action. If no tab is specified, the non-tab-specific badge text is returned. If {@link declarativeNetRequest.ExtensionActionOptions.displayActionCountAsBadgeText displayActionCountAsBadgeText} is enabled, a placeholder text will be returned unless the {@link runtime.ManifestPermission declarativeNetRequestFeedback} permission is present or tab-specific badge text was provided.
          *
          * Can return its result via Promise.
          */
@@ -7776,7 +7776,7 @@ declare namespace chrome {
             /** The list of host permissions, including those specified in the `optional_permissions` or `permissions` keys in the manifest, and those associated with [Content Scripts](https://developer.chrome.com/docs/extensions/develop/concepts/content-scripts). */
             origins?: string[];
             /** List of named permissions (does not include hosts or origins). */
-            permissions?: chrome.runtime.ManifestPermissions[];
+            permissions?: chrome.runtime.ManifestPermission[];
         }
 
         export interface AddHostAccessRequest {
@@ -9082,7 +9082,7 @@ declare namespace chrome {
         }
 
         /** Source: https://developer.chrome.com/docs/extensions/reference/permissions-list */
-        export type ManifestPermissions =
+        export type ManifestPermission =
             | "accessibilityFeatures.modify"
             | "accessibilityFeatures.read"
             | "activeTab"
@@ -9166,9 +9166,14 @@ declare namespace chrome {
             | "webRequestBlocking"
             | "webRequestAuthProvider";
 
+        /**
+         * @deprecated Use `ManifestPermission` instead.
+         */
+        export type ManifestPermissions = ManifestPermission;
+
         /** Source : https://developer.chrome.com/docs/extensions/reference/api/permissions */
-        export type ManifestOptionalPermissions = Exclude<
-            ManifestPermissions,
+        export type ManifestOptionalPermission = Exclude<
+            ManifestPermission,
             | "debugger"
             | "declarativeNetRequest"
             | "devtools"
@@ -9183,6 +9188,11 @@ declare namespace chrome {
             | "webAuthenticationProxy"
         >;
 
+        /**
+         * @deprecated Use `ManifestOptionalPermission` instead.
+         */
+        export type ManifestOptionalPermissions = ManifestOptionalPermission;
+
         export interface SearchProvider {
             name?: string | undefined;
             keyword?: string | undefined;
@@ -9402,8 +9412,8 @@ declare namespace chrome {
                 }
                 | undefined;
             content_security_policy?: string | undefined;
-            optional_permissions?: ManifestOptionalPermissions[] | string[] | undefined;
-            permissions?: ManifestPermissions[] | string[] | undefined;
+            optional_permissions?: (ManifestOptionalPermission | string)[] | undefined;
+            permissions?: (ManifestPermission | string)[] | undefined;
             web_accessible_resources?: string[] | undefined;
         }
 
@@ -9438,9 +9448,9 @@ declare namespace chrome {
                 sandbox?: string;
             };
             host_permissions?: string[] | undefined;
-            optional_permissions?: ManifestOptionalPermissions[] | undefined;
+            optional_permissions?: ManifestOptionalPermission[] | undefined;
             optional_host_permissions?: string[] | undefined;
-            permissions?: ManifestPermissions[] | undefined;
+            permissions?: ManifestPermission[] | undefined;
             web_accessible_resources?:
                 | Array<
                     & {

types/chrome/test/index.ts

@@ -1036,8 +1036,13 @@ function testGetManifest() {
         manifest.content_security_policy; // $ExpectType string | undefined
 
         manifest.host_permissions; // $ExpectType any
-        manifest.optional_permissions; // $ExpectType ManifestOptionalPermissions[] | string[] | undefined
-        manifest.permissions; // $ExpectType ManifestPermissions[] |string[] | undefined
+        manifest.optional_permissions; // $ExpectType string[] | undefined
+        manifest.permissions; // $ExpectType string[] | undefined
+        // Verify that string permissions can be added.
+        if (manifest.optional_permissions && manifest.permissions) {
+            manifest.optional_permissions.push("*://developer.mozilla.org/*");
+            manifest.permissions.push("*://developer.mozilla.org/*");
+        }
 
         manifest.web_accessible_resources; // $ExpectType string[] | undefined
     } else if (manifest.manifest_version === 3) {
@@ -1051,9 +1056,9 @@ function testGetManifest() {
         };
 
         manifest.host_permissions; // $ExpectType string[] | undefined
-        manifest.optional_permissions; // $ExpectType ManifestOptionalPermissions[] | undefined
+        manifest.optional_permissions; // $ExpectType ManifestOptionalPermission[] | undefined
         manifest.optional_host_permissions; // $ExpectType string[] | undefined
-        manifest.permissions; // $ExpectType ManifestPermissions[] | undefined
+        manifest.permissions; // $ExpectType ManifestPermission[] | undefined
 
         manifest.web_accessible_resources = [{
             resources: ["resource.js"],