Skip to content

Commit 3377f10

Browse files
authored
🤖 Merge PR DefinitelyTyped#72780 fix(forge-viewer): add optional RegExp parameters to getPropertyHashes by @moeBabazadeh
1 parent c89689c commit 3377f10

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

‎types/forge-viewer/forge-viewer-tests.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -689,6 +689,7 @@ async function selectiveLoadingTest(viewer: Autodesk.Viewing.GuiViewer3D): Promi
689689
await viewer.waitForLoadDone();
690690

691691
const propHashes = await fakeLoadedModel.getPropertyHashes();
692+
const propHashesWithFiltering = await fakeLoadedModel.getPropertyHashes(/name/, /category/);
692693
viewer.unloadDocumentNode(fakeLoadedModel.getDocumentNode());
693694

694695
const matches = JSON.stringify(query).matchAll(/(["'])\?([\w\d\s]+)\1/g);

‎types/forge-viewer/index.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -783,7 +783,7 @@ declare namespace Autodesk {
783783
needsExternalId?: boolean | undefined;
784784
},
785785
): Promise<PropertySet>;
786-
getPropertyHashes(): Promise<string[]>;
786+
getPropertyHashes(nameRE?: RegExp, categoryRE?: RegExp): Promise<string[]>;
787787
geomPolyCount(): number;
788788
getDefaultCamera(): THREE.Camera;
789789
getDisplayUnit(): string;

0 commit comments

Comments
 (0)