🤖 Merge PR DefinitelyTyped#71245 [@types/hotwired__turbo] Add missing fields to TurboSubmitEndEvent by @nanaya

Author: nanaya

types/hotwired__turbo/hotwired__turbo-tests.ts

@@ -95,3 +95,15 @@ document.addEventListener("turbo:frame-missing", function(event) {
 document.addEventListener("turbo:submit-start", function(event) {
     event.detail.formSubmission.stop();
 });
+
+document.addEventListener("turbo:submit-end", function(event) {
+    if (event.detail.success) {
+        // $ExpectType FetchResponse
+        event.detail.fetchResponse;
+    } else {
+        // $ExpectType Error|undefined
+        event.detail.error;
+        // $ExpectType FetchResponse|undefined
+        event.detail.fetchResponse;
+    }
+});

types/hotwired__turbo/index.d.ts

@@ -187,18 +187,16 @@ export interface FormSubmission {
     submitter?: HTMLButtonElement | HTMLInputElement;
 }
 export type FormSubmissionResult =
-    | { success: boolean; fetchResponse: FetchResponse }
-    | { success: false; error: Error };
+    & { formSubmission: FormSubmission }
+    & (
+        | { success: true; error: undefined; fetchResponse: FetchResponse }
+        | { success: false; error?: Error; fetchResponse?: FetchResponse }
+    );
 
 export type TurboSubmitStartEvent = CustomEvent<{
     formSubmission: FormSubmission;
 }>;
-export type TurboSubmitEndEvent = CustomEvent<
-    & { formSubmission: FormSubmission }
-    & {
-        [K in keyof FormSubmissionResult]?: FormSubmissionResult[K];
-    }
->;
+export type TurboSubmitEndEvent = CustomEvent<FormSubmissionResult>;
 
 export type TurboFrameMissingEvent = CustomEvent<{
     response: Response;