🤖 Merge PR DefinitelyTyped#72321 [ws] Update type of finishRequest to match documentation. by @yjwong

Author: yjwong

types/ws/index.d.mts

@@ -237,7 +237,7 @@ declare namespace WebSocket {
      * headers. If finishRequest is set, then it has the responsibility to call
      * request.end() once it is done setting request headers.
      */
-    type FinishRequestCallback = (request: IncomingMessage, websocket: WebSocket) => void;
+    type FinishRequestCallback = (request: ClientRequest, websocket: WebSocket) => void;
 
     interface ClientOptions extends SecureContextOptions {
         protocol?: string | undefined;

types/ws/index.d.ts

@@ -240,7 +240,7 @@ declare namespace WebSocket {
      * headers. If finishRequest is set, then it has the responsibility to call
      * request.end() once it is done setting request headers.
      */
-    type FinishRequestCallback = (request: IncomingMessage, websocket: WebSocket) => void;
+    type FinishRequestCallback = (request: ClientRequest, websocket: WebSocket) => void;
 
     interface ClientOptions extends SecureContextOptions {
         protocol?: string | undefined;

types/ws/ws-tests.mts

@@ -525,7 +525,7 @@ declare module "ws" {
         autoPong: false,
         createConnection: net.createConnection,
         finishRequest: (req, socket) => {
-            // $ExpectType IncomingMessage
+            // $ExpectType ClientRequest
             req;
 
             // $ExpectType WebSocket

types/ws/ws-tests.ts

@@ -517,7 +517,7 @@ declare module "ws" {
         autoPong: false,
         createConnection: net.createConnection,
         finishRequest: (req, socket) => {
-            // $ExpectType IncomingMessage
+            // $ExpectType ClientRequest
             req;
 
             // $ExpectType WebSocket