🤖 Merge PR DefinitelyTyped#71864 [Chrome] Add addHostAccessRequest and removeHostAccessRequest for permissions since Chrome 133 by @erwanjugand

Co-authored-by: fregante <[email protected]>

Author: erwanjugand

types/chrome/index.d.ts

@@ -6826,6 +6826,22 @@ declare namespace chrome {
             permissions?: chrome.runtime.ManifestPermissions[];
         }
 
+        export interface AddHostAccessRequest {
+            /** The id of a document where host access requests can be shown. Must be the top-level document within a tab. If provided, the request is shown on the tab of the specified document and is removed when the document navigates to a new origin. Adding a new request will override any existent request for `tabId`. This or `tabId` must be specified. */
+            documentId?: string;
+            /** The URL pattern where host access requests can be shown. If provided, host access requests will only be shown on URLs that match this pattern. */
+            pattern?: string;
+            /** The id of the tab where host access requests can be shown. If provided, the request is shown on the specified tab and is removed when the tab navigates to a new origin. Adding a new request will override an existent request for `documentId`. This or `documentId` must be specified. */
+            tabId?: number;
+        }
+
+        /**
+         * Adds a host access request. Request will only be signaled to the user if extension can be granted access to the host in the request. Request will be reset on cross-origin navigation. When accepted, grants persistent access to the site’s top origin
+         * @since Chrome 133
+         */
+        export function addHostAccessRequest(request: AddHostAccessRequest): Promise<void>;
+        export function addHostAccessRequest(request: AddHostAccessRequest, callback: () => void): void;
+
         /**
          * Checks if the extension has the specified permissions.
          * Can return its result via Promise in Manifest V3 or later since Chrome 96.
@@ -6858,6 +6874,22 @@ declare namespace chrome {
         export function remove(permissions: Permissions): Promise<boolean>;
         export function remove(permissions: Permissions, callback: (removed: boolean) => void): void;
 
+        export interface RemoveHostAccessRequest {
+            /** The id of a document where host access request will be removed. Must be the top-level document within a tab. This or `tabId` must be specified. */
+            documentId?: string;
+            /** The URL pattern where host access request will be removed. If provided, this must exactly match the pattern of an existing host access request. */
+            pattern?: string;
+            /** The id of the tab where host access request will be removed. This or `documentId` must be specified. */
+            tabId?: number;
+        }
+
+        /**
+         * Removes a host access request, if existent.
+         * @since Chrome 133
+         */
+        export function removeHostAccessRequest(request: RemoveHostAccessRequest): Promise<void>;
+        export function removeHostAccessRequest(request: RemoveHostAccessRequest, callback: () => void): void;
+
         /** Fired when access to permissions has been removed from the extension. */
         export const onRemoved: chrome.events.Event<(permissions: Permissions) => void>;
 
@@ -8629,7 +8661,7 @@ declare namespace chrome {
         export function connectNative(application: string): Port;
         /**
          * Retrieves the JavaScript 'window' object for the background page running inside the current extension/app. If the background page is an event page, the system will ensure it is loaded before calling the callback. If there is no background page, an error is set.
-         * @deprecated Background pages do not exist in MV3 extensions.
+         * @deprecated Removed since Chrome 133. Background pages do not exist in MV3 extensions.
          */
         export function getBackgroundPage(): Promise<Window>;
         /** Retrieves the JavaScript 'window' object for the background page running inside the current extension/app. If the background page is an event page, the system will ensure it is loaded before calling the callback. If there is no background page, an error is set. */

types/chrome/test/index.ts

@@ -2693,6 +2693,17 @@ function testPermissions() {
         origins: ["https://example.com/*"],
     };
 
+    const request: chrome.permissions.AddHostAccessRequest | chrome.permissions.RemoveHostAccessRequest = {
+        documentId: "1",
+        pattern: "",
+        tabId: 1,
+    };
+
+    chrome.permissions.addHostAccessRequest(request); // $ExpectType Promise<void>
+    chrome.permissions.addHostAccessRequest(request, () => {}); // $ExpectType void
+    // @ts-expect-error
+    chrome.permissions.addHostAccessRequest(request, () => {}).then(() => {});
+
     chrome.permissions.contains(permissions); // $ExpectType Promise<boolean>
     chrome.permissions.contains(permissions, (result: boolean) => {}); // $ExpectType void
     // @ts-expect-error
@@ -2719,6 +2730,11 @@ function testPermissions() {
     // @ts-expect-error : 'test' is not a recognized permission.
     chrome.permissions.remove({ permissions: ["test"] });
 
+    chrome.permissions.removeHostAccessRequest(request); // $ExpectType Promise<void>
+    chrome.permissions.removeHostAccessRequest(request, () => {}); // $ExpectType void
+    // @ts-expect-error
+    chrome.permissions.removeHostAccessRequest(request, () => {}).then(() => {});
+
     chrome.permissions.onAdded.addListener((permissions) => {
         permissions; // $ExpectType Permissions
     });