Skip to content

Commit 5f17174

Browse files
alexfauquettealexfauquette
authored
[react] Use string union for textAnchor and dominatBaseline (DefinitelyTyped#73510)
1 parent 9a1eaa2 commit 5f17174

File tree

10 files changed

+150
-18
lines changed

10 files changed

+150
-18
lines changed

‎types/react/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3572,7 +3572,21 @@ declare namespace React {
35723572
direction?: number | string | undefined;
35733573
display?: number | string | undefined;
35743574
divisor?: number | string | undefined;
3575-
dominantBaseline?: number | string | undefined;
3575+
dominantBaseline?:
3576+
| "auto"
3577+
| "use-script"
3578+
| "no-change"
3579+
| "reset-size"
3580+
| "ideographic"
3581+
| "alphabetic"
3582+
| "hanging"
3583+
| "mathematical"
3584+
| "central"
3585+
| "middle"
3586+
| "text-after-edge"
3587+
| "text-before-edge"
3588+
| "inherit"
3589+
| undefined;
35763590
dur?: number | string | undefined;
35773591
dx?: number | string | undefined;
35783592
dy?: number | string | undefined;
@@ -3719,7 +3733,7 @@ declare namespace React {
37193733
tableValues?: number | string | undefined;
37203734
targetX?: number | string | undefined;
37213735
targetY?: number | string | undefined;
3722-
textAnchor?: string | undefined;
3736+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
37233737
textDecoration?: number | string | undefined;
37243738
textLength?: number | string | undefined;
37253739
textRendering?: number | string | undefined;

‎types/react/ts5.0/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3570,7 +3570,21 @@ declare namespace React {
35703570
direction?: number | string | undefined;
35713571
display?: number | string | undefined;
35723572
divisor?: number | string | undefined;
3573-
dominantBaseline?: number | string | undefined;
3573+
dominantBaseline?:
3574+
| "auto"
3575+
| "use-script"
3576+
| "no-change"
3577+
| "reset-size"
3578+
| "ideographic"
3579+
| "alphabetic"
3580+
| "hanging"
3581+
| "mathematical"
3582+
| "central"
3583+
| "middle"
3584+
| "text-after-edge"
3585+
| "text-before-edge"
3586+
| "inherit"
3587+
| undefined;
35743588
dur?: number | string | undefined;
35753589
dx?: number | string | undefined;
35763590
dy?: number | string | undefined;
@@ -3717,7 +3731,7 @@ declare namespace React {
37173731
tableValues?: number | string | undefined;
37183732
targetX?: number | string | undefined;
37193733
targetY?: number | string | undefined;
3720-
textAnchor?: string | undefined;
3734+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
37213735
textDecoration?: number | string | undefined;
37223736
textLength?: number | string | undefined;
37233737
textRendering?: number | string | undefined;

‎types/react/ts5.0/v18/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3733,7 +3733,21 @@ declare namespace React {
37333733
direction?: number | string | undefined;
37343734
display?: number | string | undefined;
37353735
divisor?: number | string | undefined;
3736-
dominantBaseline?: number | string | undefined;
3736+
dominantBaseline?:
3737+
| "auto"
3738+
| "use-script"
3739+
| "no-change"
3740+
| "reset-size"
3741+
| "ideographic"
3742+
| "alphabetic"
3743+
| "hanging"
3744+
| "mathematical"
3745+
| "central"
3746+
| "middle"
3747+
| "text-after-edge"
3748+
| "text-before-edge"
3749+
| "inherit"
3750+
| undefined;
37373751
dur?: number | string | undefined;
37383752
dx?: number | string | undefined;
37393753
dy?: number | string | undefined;
@@ -3880,7 +3894,7 @@ declare namespace React {
38803894
tableValues?: number | string | undefined;
38813895
targetX?: number | string | undefined;
38823896
targetY?: number | string | undefined;
3883-
textAnchor?: string | undefined;
3897+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
38843898
textDecoration?: number | string | undefined;
38853899
textLength?: number | string | undefined;
38863900
textRendering?: number | string | undefined;

‎types/react/ts5.0/v18/ts5.0/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3734,7 +3734,21 @@ declare namespace React {
37343734
direction?: number | string | undefined;
37353735
display?: number | string | undefined;
37363736
divisor?: number | string | undefined;
3737-
dominantBaseline?: number | string | undefined;
3737+
dominantBaseline?:
3738+
| "auto"
3739+
| "use-script"
3740+
| "no-change"
3741+
| "reset-size"
3742+
| "ideographic"
3743+
| "alphabetic"
3744+
| "hanging"
3745+
| "mathematical"
3746+
| "central"
3747+
| "middle"
3748+
| "text-after-edge"
3749+
| "text-before-edge"
3750+
| "inherit"
3751+
| undefined;
37383752
dur?: number | string | undefined;
37393753
dx?: number | string | undefined;
37403754
dy?: number | string | undefined;
@@ -3881,7 +3895,7 @@ declare namespace React {
38813895
tableValues?: number | string | undefined;
38823896
targetX?: number | string | undefined;
38833897
targetY?: number | string | undefined;
3884-
textAnchor?: string | undefined;
3898+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
38853899
textDecoration?: number | string | undefined;
38863900
textLength?: number | string | undefined;
38873901
textRendering?: number | string | undefined;

‎types/react/v15/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3311,7 +3311,21 @@ declare namespace React {
33113311
direction?: number | string | undefined;
33123312
display?: number | string | undefined;
33133313
divisor?: number | string | undefined;
3314-
dominantBaseline?: number | string | undefined;
3314+
dominantBaseline?:
3315+
| "auto"
3316+
| "use-script"
3317+
| "no-change"
3318+
| "reset-size"
3319+
| "ideographic"
3320+
| "alphabetic"
3321+
| "hanging"
3322+
| "mathematical"
3323+
| "central"
3324+
| "middle"
3325+
| "text-after-edge"
3326+
| "text-before-edge"
3327+
| "inherit"
3328+
| undefined;
33153329
dur?: number | string | undefined;
33163330
dx?: number | string | undefined;
33173331
dy?: number | string | undefined;
@@ -3457,7 +3471,7 @@ declare namespace React {
34573471
tableValues?: number | string | undefined;
34583472
targetX?: number | string | undefined;
34593473
targetY?: number | string | undefined;
3460-
textAnchor?: string | undefined;
3474+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
34613475
textDecoration?: number | string | undefined;
34623476
textLength?: number | string | undefined;
34633477
textRendering?: number | string | undefined;

‎types/react/v16/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2601,7 +2601,21 @@ declare namespace React {
26012601
direction?: number | string | undefined;
26022602
display?: number | string | undefined;
26032603
divisor?: number | string | undefined;
2604-
dominantBaseline?: number | string | undefined;
2604+
dominantBaseline?:
2605+
| "auto"
2606+
| "use-script"
2607+
| "no-change"
2608+
| "reset-size"
2609+
| "ideographic"
2610+
| "alphabetic"
2611+
| "hanging"
2612+
| "mathematical"
2613+
| "central"
2614+
| "middle"
2615+
| "text-after-edge"
2616+
| "text-before-edge"
2617+
| "inherit"
2618+
| undefined;
26052619
dur?: number | string | undefined;
26062620
dx?: number | string | undefined;
26072621
dy?: number | string | undefined;
@@ -2748,7 +2762,7 @@ declare namespace React {
27482762
tableValues?: number | string | undefined;
27492763
targetX?: number | string | undefined;
27502764
targetY?: number | string | undefined;
2751-
textAnchor?: string | undefined;
2765+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
27522766
textDecoration?: number | string | undefined;
27532767
textLength?: number | string | undefined;
27542768
textRendering?: number | string | undefined;

‎types/react/v17/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2630,7 +2630,21 @@ declare namespace React {
26302630
direction?: number | string | undefined;
26312631
display?: number | string | undefined;
26322632
divisor?: number | string | undefined;
2633-
dominantBaseline?: number | string | undefined;
2633+
dominantBaseline?:
2634+
| "auto"
2635+
| "use-script"
2636+
| "no-change"
2637+
| "reset-size"
2638+
| "ideographic"
2639+
| "alphabetic"
2640+
| "hanging"
2641+
| "mathematical"
2642+
| "central"
2643+
| "middle"
2644+
| "text-after-edge"
2645+
| "text-before-edge"
2646+
| "inherit"
2647+
| undefined;
26342648
dur?: number | string | undefined;
26352649
dx?: number | string | undefined;
26362650
dy?: number | string | undefined;
@@ -2777,7 +2791,7 @@ declare namespace React {
27772791
tableValues?: number | string | undefined;
27782792
targetX?: number | string | undefined;
27792793
targetY?: number | string | undefined;
2780-
textAnchor?: string | undefined;
2794+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
27812795
textDecoration?: number | string | undefined;
27822796
textLength?: number | string | undefined;
27832797
textRendering?: number | string | undefined;

‎types/react/v18/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3751,7 +3751,21 @@ declare namespace React {
37513751
direction?: number | string | undefined;
37523752
display?: number | string | undefined;
37533753
divisor?: number | string | undefined;
3754-
dominantBaseline?: number | string | undefined;
3754+
dominantBaseline?:
3755+
| "auto"
3756+
| "use-script"
3757+
| "no-change"
3758+
| "reset-size"
3759+
| "ideographic"
3760+
| "alphabetic"
3761+
| "hanging"
3762+
| "mathematical"
3763+
| "central"
3764+
| "middle"
3765+
| "text-after-edge"
3766+
| "text-before-edge"
3767+
| "inherit"
3768+
| undefined;
37553769
dur?: number | string | undefined;
37563770
dx?: number | string | undefined;
37573771
dy?: number | string | undefined;
@@ -3898,7 +3912,7 @@ declare namespace React {
38983912
tableValues?: number | string | undefined;
38993913
targetX?: number | string | undefined;
39003914
targetY?: number | string | undefined;
3901-
textAnchor?: string | undefined;
3915+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
39023916
textDecoration?: number | string | undefined;
39033917
textLength?: number | string | undefined;
39043918
textRendering?: number | string | undefined;

‎types/react/v18/test/elementAttributes.tsx‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ const testCases = [
4646
<svg>
4747
<image crossOrigin="anonymous" />
4848
<circle transformOrigin="0 0" />
49+
<text
50+
// @ts-expect-error -- The correct value is "middle".
51+
textAnchor="center"
52+
// @ts-expect-error -- The correct value is "middle".
53+
dominantBaseline="center"
54+
/>
4955
</svg>,
5056
<details open={true} onToggle={() => {}} name="foo" />,
5157
<input value={["one", "two"] as readonly string[]} />,

‎types/react/v18/ts5.0/index.d.ts‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3752,7 +3752,21 @@ declare namespace React {
37523752
direction?: number | string | undefined;
37533753
display?: number | string | undefined;
37543754
divisor?: number | string | undefined;
3755-
dominantBaseline?: number | string | undefined;
3755+
dominantBaseline?:
3756+
| "auto"
3757+
| "use-script"
3758+
| "no-change"
3759+
| "reset-size"
3760+
| "ideographic"
3761+
| "alphabetic"
3762+
| "hanging"
3763+
| "mathematical"
3764+
| "central"
3765+
| "middle"
3766+
| "text-after-edge"
3767+
| "text-before-edge"
3768+
| "inherit"
3769+
| undefined;
37563770
dur?: number | string | undefined;
37573771
dx?: number | string | undefined;
37583772
dy?: number | string | undefined;
@@ -3899,7 +3913,7 @@ declare namespace React {
38993913
tableValues?: number | string | undefined;
39003914
targetX?: number | string | undefined;
39013915
targetY?: number | string | undefined;
3902-
textAnchor?: string | undefined;
3916+
textAnchor?: "start" | "middle" | "end" | "inherit" | undefined;
39033917
textDecoration?: number | string | undefined;
39043918
textLength?: number | string | undefined;
39053919
textRendering?: number | string | undefined;

0 commit comments

Comments
 (0)