🤖 Merge PR DefinitelyTyped#73971 feat(rails__actioncable): Add Consumer.addSubProtocol method by @shunichi

shunichi · web-flow · commit 62937f5cee29 · 2025-10-26T23:35:09.000-07:00
diff --git a/types/rails__actioncable/index.d.ts b/types/rails__actioncable/index.d.ts
@@ -18,11 +18,13 @@ export const adapters: {
  */
 export class Consumer {
     readonly subscriptions: Subscriptions;
+    readonly subprotocols: string[];
 
     constructor(url: string);
     get url(): string;
     connect(): boolean;
     disconnect(): void;
+    addSubProtocol(protocol: string): void;
 }
 
 export interface BaseMixin {
diff --git a/types/rails__actioncable/rails__actioncable-tests.ts b/types/rails__actioncable/rails__actioncable-tests.ts
@@ -9,9 +9,11 @@ const consumer = createConsumer("url"); // $ExpectType Consumer
 createConsumer(() => "url"); // $ExpectType Consumer
 
 consumer.url; // $ExpectType string
+consumer.subprotocols; // $ExpectType string[]
 
 consumer.connect(); // $ExpectType boolean
 consumer.disconnect(); // $ExpectType void
+consumer.addSubProtocol("custom-protocol"); // $ExpectType void
 
 {
     const subscription = consumer.subscriptions.create(

Original file line number	Diff line number	Diff line change
`@@ -9,9 +9,11 @@ const consumer = createConsumer("url"); // $ExpectType Consumer`
`9`	`9`	`createConsumer(() => "url"); // $ExpectType Consumer`
`10`	`10`
`11`	`11`	`consumer.url; // $ExpectType string`
	`12`	`+consumer.subprotocols; // $ExpectType string[]`
`12`	`13`
`13`	`14`	`consumer.connect(); // $ExpectType boolean`
`14`	`15`	`consumer.disconnect(); // $ExpectType void`
	`16`	`+consumer.addSubProtocol("custom-protocol"); // $ExpectType void`
`15`	`17`
`16`	`18`	`{`
`17`	`19`	`const subscription = consumer.subscriptions.create(`