🤖 Merge PR DefinitelyTyped#74177 Add support for additional DataSource fields to chartmogul-node by @wscourge

Author: wscourge

types/chartmogul-node/chartmogul-node-tests.ts

@@ -15,6 +15,13 @@ ChartMogul.DataSource.create(config, {
 // $ExpectType Promise<DataSource>
 ChartMogul.DataSource.retrieve(config, "");
 
+// $ExpectType Promise<DataSource>
+ChartMogul.DataSource.retrieve(config, "", {
+    with_processing_status: true,
+    with_auto_churn_subscription_setting: true,
+    with_invoice_handling_setting: true,
+});
+
 // $ExpectType Promise<{}>
 ChartMogul.DataSource.destroy(config, "");
 
@@ -23,9 +30,24 @@ ChartMogul.DataSource.all(config, {
     name: "",
 });
 
+// $ExpectType Promise<DataSources>
+ChartMogul.DataSource.all(config, {
+    name: "",
+    system: "",
+    with_processing_status: true,
+    with_auto_churn_subscription_setting: true,
+    with_invoice_handling_setting: true,
+});
+
 ChartMogul.DataSource.all(config).then(data => {
     data.data_sources[0]; // $ExpectType DataSource
     data.data_sources[0].name; // $ExpectType string
+    data.data_sources[0].processing_status!.processed!; // $ExpectType number
+    data.data_sources[0].processing_status!.pending!; // $ExpectType number
+    data.data_sources[0].processing_status!.failed!; // $ExpectType number
+    data.data_sources[0].auto_churn_subscription_setting!.enabled; // $ExpectType boolean
+    data.data_sources[0].auto_churn_subscription_setting!.interval; // $ExpectType number | null
+    data.data_sources[0].invoice_handling_setting; // $ExpectType Record<string, any> | undefined
 });
 
 // $ExpectType Promise<Customer>

types/chartmogul-node/index.d.ts

@@ -14,23 +14,48 @@ export namespace Ping {
 }
 
 export namespace DataSource {
+    type DataSourceStatus =
+        | "never_imported"
+        | "import_complete"
+        | "import_in_progress"
+        | "import_failed"
+        | string
+        | undefined;
+
+    interface ProcessingStatus {
+        processed?: number;
+        pending?: number;
+        failed?: number;
+    }
+    interface AutoChurnSubscriptionSetting {
+        enabled: boolean;
+        interval: number | null;
+    }
+    interface ExtraDataSourceParams {
+        with_processing_status?: boolean;
+        with_auto_churn_subscription_setting?: boolean;
+        with_invoice_handling_setting?: boolean;
+    }
+    interface ListDataSourcesParams extends ExtraDataSourceParams {
+        name?: string;
+        system?: string;
+    }
     interface DataSource {
-        uuid?: string | undefined;
+        uuid?: string;
         name: string;
-        created_at?: string | undefined;
-        status?: string | undefined;
-        system?: string | undefined;
+        created_at?: string;
+        status?: DataSourceStatus;
+        system?: string;
+        processing_status?: ProcessingStatus;
+        auto_churn_subscription_setting?: AutoChurnSubscriptionSetting;
+        invoice_handling_setting?: Record<string, any>;
     }
     interface DataSources {
         data_sources: DataSource[];
     }
-    interface ListDataSourcesParams {
-        name?: string | undefined;
-        system?: string | undefined;
-    }
 
     function create(config: Config, data: DataSource): Promise<DataSource>;
-    function retrieve(config: Config, uuid: string): Promise<DataSource>;
+    function retrieve(config: Config, uuid: string, params?: ExtraDataSourceParams): Promise<DataSource>;
     function destroy(config: Config, uuid: string): Promise<{}>;
     function all(config: Config, params?: ListDataSourcesParams): Promise<DataSources>;
 }

types/chartmogul-node/package.json

@@ -1,7 +1,7 @@
 {
     "private": true,
     "name": "@types/chartmogul-node",
-    "version": "2.0.9999",
+    "version": "3.8.9999",
     "projects": [
         "https://github.com/chartmogul/chartmogul-node"
     ],