Skip to content

Commit 96c9dd4

Browse files
authored
🤖 Merge PR DefinitelyTyped#72591 [chrome] no unsafe function type by @erwanjugand
1 parent 864c2a2 commit 96c9dd4

File tree

4 files changed

+54
-55
lines changed

4 files changed

+54
-55
lines changed

types/chrome/.eslintrc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"rules": {
33
"@definitelytyped/no-unnecessary-generics": "off",
44
"@definitelytyped/strict-export-declare-modifiers": "off",
5-
"@typescript-eslint/no-unsafe-function-type": "off",
65
"@typescript-eslint/no-wrapper-object-types": "off",
76
"@typescript-eslint/prefer-namespace": "off",
87
"@typescript-eslint/no-empty-interface": "off"

types/chrome/chrome-cast/index.d.ts

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ declare namespace chrome {
110110
*/
111111
export function initialize(
112112
apiConfig: chrome.cast.ApiConfig,
113-
successCallback: Function,
113+
successCallback: () => void,
114114
errorCallback: (error: chrome.cast.Error) => void,
115115
): void;
116116

@@ -158,7 +158,7 @@ declare namespace chrome {
158158
*/
159159
export function setCustomReceivers(
160160
receivers: chrome.cast.Receiver[],
161-
successCallback: Function,
161+
successCallback: () => void,
162162
errorCallback: (error: chrome.cast.Error) => void,
163163
): void;
164164

@@ -169,7 +169,7 @@ declare namespace chrome {
169169
*/
170170
export function setReceiverDisplayStatus(
171171
receiver: chrome.cast.Receiver,
172-
successCallback: Function,
172+
successCallback: () => void,
173173
errorCallback: (error: chrome.cast.Error) => void,
174174
): void;
175175

@@ -292,7 +292,7 @@ declare namespace chrome {
292292
*/
293293
setReceiverVolumeLevel(
294294
newLevel: number,
295-
successCallback: Function,
295+
successCallback: () => void,
296296
errorCallback: (error: chrome.cast.Error) => void,
297297
): void;
298298

@@ -303,21 +303,21 @@ declare namespace chrome {
303303
*/
304304
setReceiverMuted(
305305
muted: boolean,
306-
successCallback: Function,
306+
successCallback: () => void,
307307
errorCallback: (error: chrome.cast.Error) => void,
308308
): void;
309309

310310
/**
311311
* @param successCallback
312312
* @param errorCallback
313313
*/
314-
leave(successCallback: Function, errorCallback: (error: chrome.cast.Error) => void): void;
314+
leave(successCallback: () => void, errorCallback: (error: chrome.cast.Error) => void): void;
315315

316316
/**
317317
* @param successCallback
318318
* @param errorCallback
319319
*/
320-
stop(successCallback: Function, errorCallback: (error: chrome.cast.Error) => void): void;
320+
stop(successCallback: () => void, errorCallback: (error: chrome.cast.Error) => void): void;
321321

322322
/**
323323
* @param namespace
@@ -328,7 +328,7 @@ declare namespace chrome {
328328
sendMessage(
329329
namespace: string,
330330
message: string | object,
331-
successCallback: Function,
331+
successCallback: () => void,
332332
errorCallback: (error: chrome.cast.Error) => void,
333333
): void;
334334

@@ -885,7 +885,7 @@ declare namespace chrome {
885885
*/
886886
getStatus(
887887
getStatusRequest: chrome.cast.media.GetStatusRequest,
888-
successCallback: Function,
888+
successCallback: () => void,
889889
errorCallback: (error: chrome.cast.Error) => void,
890890
): void;
891891

@@ -896,7 +896,7 @@ declare namespace chrome {
896896
*/
897897
play(
898898
playRequest: chrome.cast.media.PlayRequest,
899-
successCallback: Function,
899+
successCallback: () => void,
900900
errorCallback: (error: chrome.cast.Error) => void,
901901
): void;
902902

@@ -907,7 +907,7 @@ declare namespace chrome {
907907
*/
908908
pause(
909909
pauseRequest: chrome.cast.media.PauseRequest,
910-
successCallback: Function,
910+
successCallback: () => void,
911911
errorCallback: (error: chrome.cast.Error) => void,
912912
): void;
913913

@@ -918,7 +918,7 @@ declare namespace chrome {
918918
*/
919919
seek(
920920
seekRequest: chrome.cast.media.SeekRequest,
921-
successCallback: Function,
921+
successCallback: () => void,
922922
errorCallback: (error: chrome.cast.Error) => void,
923923
): void;
924924

@@ -929,7 +929,7 @@ declare namespace chrome {
929929
*/
930930
stop(
931931
stopRequest: chrome.cast.media.StopRequest,
932-
successCallback: Function,
932+
successCallback: () => void,
933933
errorCallback: (error: chrome.cast.Error) => void,
934934
): void;
935935

@@ -940,7 +940,7 @@ declare namespace chrome {
940940
*/
941941
setVolume(
942942
volumeRequest: chrome.cast.media.VolumeRequest,
943-
successCallback: Function,
943+
successCallback: () => void,
944944
errorCallback: (error: chrome.cast.Error) => void,
945945
): void;
946946

@@ -951,7 +951,7 @@ declare namespace chrome {
951951
*/
952952
editTracksInfo(
953953
editTracksInfoRequest: chrome.cast.media.EditTracksInfoRequest,
954-
successCallback: Function,
954+
successCallback: () => void,
955955
errorCallback: (error: chrome.cast.Error) => void,
956956
): void;
957957

@@ -984,7 +984,7 @@ declare namespace chrome {
984984
*/
985985
queueAppendItem(
986986
item: chrome.cast.media.QueueItem,
987-
successCallback: Function,
987+
successCallback: () => void,
988988
errorCallback: (error: chrome.cast.Error) => void,
989989
): void;
990990

@@ -995,7 +995,7 @@ declare namespace chrome {
995995
*/
996996
queueInsertItems(
997997
queueInsertItemsRequest: chrome.cast.media.QueueInsertItemsRequest,
998-
successCallback: Function,
998+
successCallback: () => void,
999999
errorCallback: (error: chrome.cast.Error) => void,
10001000
): void;
10011001

@@ -1006,7 +1006,7 @@ declare namespace chrome {
10061006
*/
10071007
queueJumpToItem(
10081008
itemId: number,
1009-
successCallback: Function,
1009+
successCallback: () => void,
10101010
errorCallback: (error: chrome.cast.Error) => void,
10111011
): void;
10121012

@@ -1019,21 +1019,21 @@ declare namespace chrome {
10191019
queueMoveItemToNewIndex(
10201020
itemId: number,
10211021
newIndex: number,
1022-
successCallback: Function,
1022+
successCallback: () => void,
10231023
errorCallback: (error: chrome.cast.Error) => void,
10241024
): void;
10251025

10261026
/**
10271027
* @param successCallback
10281028
* @param errorCallback
10291029
*/
1030-
queueNext(successCallback: Function, errorCallback: (error: chrome.cast.Error) => void): void;
1030+
queueNext(successCallback: () => void, errorCallback: (error: chrome.cast.Error) => void): void;
10311031

10321032
/**
10331033
* @param successCallback
10341034
* @param errorCallback
10351035
*/
1036-
queuePrev(successCallback: Function, errorCallback: (error: chrome.cast.Error) => void): void;
1036+
queuePrev(successCallback: () => void, errorCallback: (error: chrome.cast.Error) => void): void;
10371037

10381038
/**
10391039
* @param itemId
@@ -1042,7 +1042,7 @@ declare namespace chrome {
10421042
*/
10431043
queueRemoveItem(
10441044
itemId: number,
1045-
successCallback: Function,
1045+
successCallback: () => void,
10461046
errorCallback: (error: chrome.cast.Error) => void,
10471047
): void;
10481048

@@ -1053,7 +1053,7 @@ declare namespace chrome {
10531053
*/
10541054
queueReorderItems(
10551055
queueReorderItemsRequest: chrome.cast.media.QueueReorderItemsRequest,
1056-
successCallback: Function,
1056+
successCallback: () => void,
10571057
errorCallback: (error: chrome.cast.Error) => void,
10581058
): void;
10591059

@@ -1064,7 +1064,7 @@ declare namespace chrome {
10641064
*/
10651065
queueSetRepeatMode(
10661066
repeatMode: chrome.cast.media.RepeatMode,
1067-
successCallback: Function,
1067+
successCallback: () => void,
10681068
errorCallback: (error: chrome.cast.Error) => void,
10691069
): void;
10701070

@@ -1075,7 +1075,7 @@ declare namespace chrome {
10751075
*/
10761076
queueUpdateItems(
10771077
queueUpdateItemsRequest: chrome.cast.media.QueueUpdateItemsRequest,
1078-
successCallback: Function,
1078+
successCallback: () => void,
10791079
errorCallback: (error: chrome.cast.Error) => void,
10801080
): void;
10811081
}

0 commit comments

Comments
 (0)