🤖 Merge PR DefinitelyTyped#71614 fix(tr46): fix return type of exported functions by @hkleungai

Author: hkleungai

types/tr46/index.d.ts

@@ -1,12 +1,18 @@
 /**
  * Converts a string of Unicode symbols to a case-folded Punycode string of ASCII symbols.
  */
-export function toASCII(domainName: string, options?: ToASCIIOptions): string;
+export function toASCII(
+    domainName: string,
+    options?: ToASCIIOptions,
+): string | null;
 
 /**
  * Converts a case-folded Punycode string of ASCII symbols to a string of Unicode symbols.
  */
-export function toUnicode(domainName: string, options?: Options): string;
+export function toUnicode(
+    domainName: string,
+    options?: Options,
+): { domain: string; error: boolean };
 
 export interface Options {
     /**

types/tr46/tr46-tests.ts

@@ -4,24 +4,24 @@ import { Options, toASCII, ToASCIIOptions, toUnicode } from "tr46";
 type O = Options;
 type TAO = ToASCIIOptions;
 
-toASCII("foo.bar"); // $ExpectType string
-toASCII("foo.bar", { checkBidi: true }); // $ExpectType string
-toASCII("foo.bar", { checkHyphens: true }); // $ExpectType string
-toASCII("foo.bar", { checkJoiners: true }); // $ExpectType string
-toASCII("foo.bar", { ignoreInvalidPunycode: true }); // $ExpectType string
-toASCII("foo.bar", { transitionalProcessing: true }); // $ExpectType string
-toASCII("foo.bar", { useSTD3ASCIIRules: true }); // $ExpectType string
-toASCII("foo.bar", { verifyDNSLength: true }); // $ExpectType string
+toASCII("foo.bar"); // $ExpectType string | null
+toASCII("foo.bar", { checkBidi: true }); // $ExpectType string | null
+toASCII("foo.bar", { checkHyphens: true }); // $ExpectType string | null
+toASCII("foo.bar", { checkJoiners: true }); // $ExpectType string | null
+toASCII("foo.bar", { ignoreInvalidPunycode: true }); // $ExpectType string | null
+toASCII("foo.bar", { transitionalProcessing: true }); // $ExpectType string | null
+toASCII("foo.bar", { useSTD3ASCIIRules: true }); // $ExpectType string | null
+toASCII("foo.bar", { verifyDNSLength: true }); // $ExpectType string | null
 // @ts-expect-error
 toASCII("foo.bar", { foo: true });
 
-toUnicode("foo.bar"); // $ExpectType string
-toUnicode("foo.bar", { checkBidi: true }); // $ExpectType string
-toUnicode("foo.bar", { checkHyphens: true }); // $ExpectType string
-toUnicode("foo.bar", { checkJoiners: true }); // $ExpectType string
-toUnicode("foo.bar", { ignoreInvalidPunycode: true }); // $ExpectType string
-toUnicode("foo.bar", { transitionalProcessing: true }); // $ExpectType string
-toUnicode("foo.bar", { useSTD3ASCIIRules: true }); // $ExpectType string
+toUnicode("foo.bar"); // $ExpectType { domain: string, error: boolean }
+toUnicode("foo.bar", { checkBidi: true }); // $ExpectType { domain: string, error: boolean }
+toUnicode("foo.bar", { checkHyphens: true }); // $ExpectType { domain: string, error: boolean }
+toUnicode("foo.bar", { checkJoiners: true }); // $ExpectType { domain: string, error: boolean }
+toUnicode("foo.bar", { ignoreInvalidPunycode: true }); // $ExpectType { domain: string, error: boolean }
+toUnicode("foo.bar", { transitionalProcessing: true }); // $ExpectType { domain: string, error: boolean }
+toUnicode("foo.bar", { useSTD3ASCIIRules: true }); // $ExpectType { domain: string, error: boolean }
 // @ts-expect-error
 toUnicode("foo.bar", { verifyDNSLength: true });
 // @ts-expect-error