Skip to content

Commit b2e155e

Browse files
🤖 Merge PR DefinitelyTyped#72542 refactor(pxroneline): update SocialVendorConsents to SocialConsents a… by @diogopxrnextday
1 parent d2c2976 commit b2e155e

File tree

3 files changed

+21
-8
lines changed

3 files changed

+21
-8
lines changed

‎types/pxr-oneline/index.d.ts‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,17 @@ declare namespace OneLine {
4949
isEmpty: string;
5050
isNotEmpty: string;
5151
ageGateReady: string;
52-
socialVendorsReady: string;
52+
purposeReady: string;
5353
};
5454
cons: {
5555
OneTime: string;
5656
};
5757
subscribe(topic: string, fn: NoParamFunction): void;
58-
subscribe(topic: EventObject["topic"]["socialVendorsReady"], fn: (data: SocialVendorConsents) => void): void;
58+
subscribe(topic: EventObject["topic"]["purposeReady"], fn: (data: SocialConsents) => void): void;
5959
broadcast(oneTime: boolean, topic: string, data?: any): void;
6060
}
6161

62-
interface SocialVendorConsents {
62+
interface SocialConsents {
6363
vendors: {
6464
tiktok: boolean;
6565
twitter: boolean;
@@ -69,11 +69,17 @@ declare namespace OneLine {
6969
google_maps: boolean;
7070
spotify: boolean;
7171
jwplayer: boolean;
72+
dailymotion: boolean;
73+
omny: boolean;
74+
vimeo: boolean;
75+
liveblog: boolean;
76+
art19: boolean;
77+
roninmedia: boolean;
7278
};
7379
}
7480

7581
type NoParamFunction = () => void;
7682
type ParamFunction = (arg: any) => void;
7783
}
7884
declare const OneLine: OneLine.OneLine;
79-
export = OneLine;
85+
export = OneLine;

‎types/pxr-oneline/oneline-tests.ts‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ interface BidderConfig {
1515
type NoParamFunction = () => void;
1616
type ParamFunction = (arg: any) => void;
1717

18-
interface SocialVendorConsents {
18+
interface SocialConsents {
1919
vendors: {
2020
tiktok: boolean;
2121
twitter: boolean;
@@ -24,6 +24,13 @@ interface SocialVendorConsents {
2424
facebook: boolean;
2525
google_maps: boolean;
2626
spotify: boolean;
27+
jwplayer: boolean;
28+
dailymotion: boolean;
29+
omny: boolean;
30+
vimeo: boolean;
31+
liveblog: boolean;
32+
art19: boolean;
33+
roninmedia: boolean;
2734
};
2835
}
2936

@@ -36,13 +43,13 @@ const ndOne: OneLine.OneLine = {
3643
isEmpty: "isEmpty",
3744
isNotEmpty: "isNotEmpty",
3845
ageGateReady: "ageGateReady",
39-
socialVendorsReady: "socialVendorsReady",
46+
purposeReady: "purposeReady",
4047
},
4148
cons: {
4249
OneTime: "OneTime",
4350
},
4451

45-
subscribe: (topic: string, fn: NoParamFunction | ((data: SocialVendorConsents) => void)) => {
52+
subscribe: (topic: string, fn: NoParamFunction | ((data: SocialConsents) => void)) => {
4653
// Mock implementation for subscribe
4754
console.log(`Subscribed to topic: ${topic}`);
4855
},

‎types/pxr-oneline/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"private": true,
33
"name": "@types/pxr-oneline",
4-
"version": "1.7.9999",
4+
"version": "1.8.9999",
55
"nonNpm": true,
66
"nonNpmDescription": "The OneLine handles all the logic needed for a publisher to serve ads.",
77
"projects": [

0 commit comments

Comments
 (0)