Skip to content

Commit b69f27d

Browse files
authored
🤖 Merge PR DefinitelyTyped#72220 [@types/backbone] fix off and stopListening definition. by @restimel
1 parent 1a56a7a commit b69f27d

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

‎types/backbone/backbone-tests.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ function test_events() {
99

1010
object.off("change", onChange);
1111
object.off("change");
12+
object.off({
13+
change: onChange,
14+
});
15+
object.off({
16+
change: onChange,
17+
}, context);
1218
object.off(null, onChange);
1319
object.off(null, null, context);
1420
object.off();
@@ -402,7 +408,11 @@ namespace v1Changes {
402408
const view = new Backbone.View<Employee>();
403409
view.stopListening(model, "invalid", () => {});
404410
view.stopListening(model, "invalid");
411+
view.stopListening(model, {
412+
invalid: () => {},
413+
});
405414
view.stopListening(model);
415+
view.stopListening();
406416
}
407417
}
408418

‎types/backbone/index.d.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ declare namespace Backbone {
148148
}
149149
interface Events_Off<BaseT> {
150150
<T extends BaseT>(this: T, eventName?: string | null, callback?: EventHandler | null, context?: any): T;
151+
<T extends BaseT>(this: T, eventMap: EventMap, context?: any): T;
151152
}
152153
interface Events_Trigger<BaseT> {
153154
<T extends BaseT>(this: T, eventName: string, ...args: any[]): T;
@@ -158,6 +159,7 @@ declare namespace Backbone {
158159
}
159160
interface Events_Stop<BaseT> {
160161
<T extends BaseT>(this: T, object?: any, events?: string, callback?: EventHandler): T;
162+
<T extends BaseT>(this: T, object: any, eventMap: EventMap): T;
161163
}
162164

163165
/**
@@ -174,6 +176,7 @@ declare namespace Backbone {
174176
on(eventName: string, callback: EventHandler, context?: any): this;
175177
on(eventMap: EventMap, context?: any): this;
176178
off(eventName?: string | null, callback?: EventHandler | null, context?: any): this;
179+
off(eventMap: EventMap, context?: any): this;
177180
trigger(eventName: string, ...args: any[]): this;
178181
bind(eventName: string, callback: EventHandler, context?: any): this;
179182
bind(eventMap: EventMap, context?: any): this;
@@ -186,6 +189,7 @@ declare namespace Backbone {
186189
listenToOnce(object: any, events: string, callback: EventHandler): this;
187190
listenToOnce(object: any, eventMap: EventMap): this;
188191
stopListening(object?: any, events?: string, callback?: EventHandler): this;
192+
stopListening(object: any, eventMap: EventMap): this;
189193
}
190194

191195
class ModelBase extends EventsMixin {

0 commit comments

Comments
 (0)