Skip to content

Commit cef76e8

Browse files
authored
🤖 Merge PR DefinitelyTyped#73788 feat(selenium-webdriver): further restrict log level to string union by @hkleungai
1 parent 1f7d05d commit cef76e8

File tree

2 files changed

+25
-9
lines changed

2 files changed

+25
-9
lines changed
Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1-
declare class FilterBy {
2-
constructor(level: string);
1+
export class FilterBy {
2+
constructor(level?: FilterByLevel);
33

4-
static logLevel(level: string | undefined): FilterBy;
5-
getLevel(): string;
4+
static logLevel(level?: FilterByLevel): FilterBy;
5+
getLevel(): FilterByLevel;
66
}
77

8-
export { FilterBy };
8+
export type FilterByLevel =
9+
| "debug"
10+
| "error"
11+
| "info"
12+
| "warning";
Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,18 @@
11
import { FilterBy } from "selenium-webdriver/bidi/filterBy";
22

3-
function TestFilterBy() {
4-
const filterBy = new FilterBy("info");
5-
filterBy.getLevel();
6-
}
3+
let filterBy: FilterBy;
4+
5+
filterBy = new FilterBy("debug");
6+
filterBy = new FilterBy("error");
7+
filterBy = new FilterBy("info");
8+
filterBy = new FilterBy("warning");
9+
filterBy = new FilterBy();
10+
11+
filterBy = FilterBy.logLevel("debug");
12+
filterBy = FilterBy.logLevel("error");
13+
filterBy = FilterBy.logLevel("info");
14+
filterBy = FilterBy.logLevel("warning");
15+
filterBy = FilterBy.logLevel();
16+
17+
// $ExpectType FilterByLevel
18+
filterBy.getLevel();

0 commit comments

Comments
 (0)