🤖 Merge PR DefinitelyTyped#73216 update node-forge to support custom csr and certificate signers by @micro-jumbo

Author: micro-jumbo

types/node-forge/index.d.ts

@@ -278,6 +278,10 @@ declare module "node-forge" {
         }
         var oids: oids;
 
+        interface MDSigner {
+            sign(md: md.MessageDigest): Bytes;
+        }
+
         namespace rsa {
             type EncryptionScheme = "RSAES-PKCS1-V1_5" | "RSA-OAEP" | "RAW" | "NONE" | null;
             type SignatureScheme = "RSASSA-PKCS1-V1_5" | pss.PSS | "NONE" | null;
@@ -472,10 +476,10 @@ declare module "node-forge" {
             /**
              * Signs this certificate using the given private key.
              *
-             * @param key the private key to sign with.
+             * @param signer the signer used to sign this csr
              * @param md the message digest object to use (defaults to forge.md.sha1).
              */
-            sign(key: pki.PrivateKey, md?: md.MessageDigest): void;
+            sign(signer: MDSigner, md?: md.MessageDigest): void;
             /**
              * Attempts verify the signature on the passed certificate using this
              * certificate's public key.
@@ -567,10 +571,10 @@ declare module "node-forge" {
             /**
              * Signs this csr using the given private key.
              *
-             * @param key the private key to sign with.
+             * @param signer the signer used to sign this csr
              * @param md the message digest object to use (defaults to forge.md.sha1).
              */
-            sign(key: pki.PrivateKey, md?: md.MessageDigest): void;
+            sign(signer: MDSigner, md?: md.MessageDigest): void;
             /**
              * Attempts verify the signature on this csr using this
              * csr's public key.