Skip to content

Commit 159c138

Browse files
adding sha to all builds (flameshot-org#4190)
1 parent 0246932 commit 159c138

File tree

5 files changed

+23
-8
lines changed

5 files changed

+23
-8
lines changed

.github/workflows/Linux-arm-pack.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ jobs:
103103
# echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV
104104
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV
105105
echo "VER_INFO=${ver_info}" >> $GITHUB_ENV
106+
echo "GIT_HASH=${git_hash}" >> $GITHUB_ENV
107+
106108
107109
- name: Get packpack tool
108110
uses: actions/checkout@v4

.github/workflows/Linux-pack.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ jobs:
9494
# echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV
9595
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV
9696
echo "VER_INFO=${ver_info}" >> $GITHUB_ENV
97+
echo "GIT_HASH=${git_hash}" >> $GITHUB_ENV
9798
9899
- name: Get packpack tool
99100
uses: actions/checkout@v4
@@ -184,6 +185,7 @@ jobs:
184185
# echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV
185186
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV
186187
echo "VER_INFO=${ver_info}" >> $GITHUB_ENV
188+
echo "GIT_HASH=${git_hash}" >> $GITHUB_ENV
187189
188190
- name: Get packpack tool
189191
uses: actions/checkout@v4
@@ -311,6 +313,7 @@ jobs:
311313
# echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV
312314
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV
313315
echo "VER_INFO=${ver_info}" >> $GITHUB_ENV
316+
echo "GIT_HASH=${git_hash}" >> $GITHUB_ENV
314317
315318
- name: Install Dependencies
316319
run: |
@@ -404,6 +407,7 @@ jobs:
404407
# echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV
405408
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV
406409
echo "VER_INFO=${ver_info}" >> $GITHUB_ENV
410+
echo "GIT_HASH=${git_hash}" >> $GITHUB_ENV
407411
408412
- name: Setup flatpak
409413
run: |
@@ -476,6 +480,7 @@ jobs:
476480
# echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV
477481
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV
478482
echo "VER_INFO=${ver_info}" >> $GITHUB_ENV
483+
echo "GIT_HASH=${git_hash}" >> $GITHUB_ENV
479484
480485
- name: Packaging snap
481486
uses: snapcore/action-build@v1

.github/workflows/MacOS-pack.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ jobs:
7272
# echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV
7373
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV
7474
echo "VER_INFO=${ver_info}" >> $GITHUB_ENV
75+
echo "GIT_HASH=${git_hash}" >> $GITHUB_ENV
7576
7677
- name: Install Qt
7778
run: brew install qt@6 cmake

.github/workflows/Windows-pack.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ jobs:
8989
# echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV
9090
echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV
9191
echo "VER_INFO=${ver_info}" >> $GITHUB_ENV
92+
echo "GIT_HASH=${git_hash}" >> $GITHUB_ENV
9293
9394
- name: Restore from cache and run vcpkg
9495
uses: lukka/run-vcpkg@v11

src/CMakeLists.txt

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -286,16 +286,22 @@ endif()
286286
message("Flameshot predefined color palette large: " ${FLAMESHOT_PREDEFINED_COLOR_PALETTE_LARGE})
287287
target_compile_definitions(flameshot PRIVATE PREDEFINED_COLOR_PALETTE_LARGE=${FLAMESHOT_PREDEFINED_COLOR_PALETTE_LARGE})
288288

289-
find_package (Git)
290-
if (GIT_FOUND)
291-
message("git found: ${GIT_EXECUTABLE} in version ${GIT_VERSION_STRING}")
292-
execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --short HEAD OUTPUT_VARIABLE FLAMESHOT_GIT_HASH)
293-
string(REGEX REPLACE "\r*\n$" "" FLAMESHOT_GIT_HASH "${FLAMESHOT_GIT_HASH}")
289+
if( DEFINED ENV{GIT_HASH})
290+
message("Using provided git_commit_hash: $ENV{GIT_HASH}")
291+
set(FLAMESHOT_GIT_HASH $ENV{GIT_HASH})
294292
target_compile_definitions(flameshot PRIVATE FLAMESHOT_GIT_HASH="${FLAMESHOT_GIT_HASH}")
295-
message("FLAMESHOT_GIT_HASH: ${FLAMESHOT_GIT_HASH}")
296293
else()
297-
target_compile_definitions(flameshot PRIVATE FLAMESHOT_GIT_HASH="-")
298-
message("git command is not found")
294+
find_package (Git)
295+
if (GIT_FOUND)
296+
message("git found: ${GIT_EXECUTABLE} in version ${GIT_VERSION_STRING}")
297+
execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --short HEAD OUTPUT_VARIABLE FLAMESHOT_GIT_HASH)
298+
string(REGEX REPLACE "\r*\n$" "" FLAMESHOT_GIT_HASH "${FLAMESHOT_GIT_HASH}")
299+
target_compile_definitions(flameshot PRIVATE FLAMESHOT_GIT_HASH="${FLAMESHOT_GIT_HASH}")
300+
message("FLAMESHOT_GIT_HASH: ${FLAMESHOT_GIT_HASH}")
301+
else()
302+
target_compile_definitions(flameshot PRIVATE FLAMESHOT_GIT_HASH="-")
303+
message("git command is not found")
304+
endif ()
299305
endif ()
300306
target_compile_definitions(flameshot PRIVATE APP_PREFIX="${CMAKE_INSTALL_PREFIX}")
301307
target_compile_definitions(flameshot PRIVATE APP_VERSION="v${PROJECT_VERSION}")

0 commit comments

Comments
 (0)