Skip to content

Commit 2004959

Browse files
authored
Fix documentations (flameshot-org#3934)
* fixes code fence symmetry * capitalized names in documentations * improves markdown styling of documentation
1 parent 90fd5fc commit 2004959

File tree

5 files changed

+25
-25
lines changed

5 files changed

+25
-25
lines changed

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ Now every time you press <kbd>Prt Sc</kbd>, it will start the Flameshot GUI inst
307307
```text
308308
Command Shortcut
309309
xfce4-screenshooter -fd 1 Print
310-
````
310+
```
311311
4. Replace `xfce4-screenshooter -fd 1` with `flameshot gui`
312312

313313
Now every time you press <kbd>Prt Sc</kbd> it will start Flameshot GUI instead of the default application.
@@ -319,7 +319,7 @@ Now every time you press <kbd>Prt Sc</kbd> it will start Flameshot GUI instead o
319319

320320
```text
321321
Print :Exec flameshot gui
322-
````
322+
```
323323
3. Refresh Fluxbox configuration with **Reconfigure** option from the menu.
324324

325325
## Considerations
@@ -480,17 +480,17 @@ brew install cmake
480480

481481
### Build
482482

483-
After installing all the dependencies, flameshot can be built.
483+
After installing all the dependencies, Flameshot can be built.
484484

485485
#### Installation/build dir
486486
For the translations to be loaded correctly, the build process needs to be aware of where you want
487-
to install flameshot.
487+
to install Flameshot.
488488

489489
```shell
490490
# Directory where build files will be placed, may be relative
491491
export BUILD_DIR=build
492492
493-
# Directory prefix where flameshot will be installed. If you are just building and don't want to
493+
# Directory prefix where Flameshot will be installed. If you are just building and don't want to
494494
# install, comment this environment variable.
495495
# This excludes the bin/flameshot part of the install,
496496
# e.g. in /opt/flameshot/bin/flameshot, the CMAKE_INSTALL_PREFIX is /opt/flameshot
@@ -507,14 +507,14 @@ cmake -S . -B "$BUILD_DIR" \
507507
&& cmake --build "$BUILD_DIR"
508508
```
509509

510-
When the `cmake --build` command has completed you can launch flameshot from the `project_folder/build/src` folder.
510+
When the `cmake --build` command has completed you can launch Flameshot from the `project_folder/build/src` folder.
511511

512512
### Install
513513

514514
Note that if you install from source, there _is no_ uninstaller, so consider installing to a custom directory.
515515

516516
#### To install into a custom directory
517-
Make sure you are using cmake `>= 3.29` and build flameshot with `$CMAKE_INSTALL_PREFIX` set to the
517+
Make sure you are using cmake `>= 3.29` and build Flameshot with `$CMAKE_INSTALL_PREFIX` set to the
518518
installation directory. If this is not done, the translations won't be found when using a custom directory.
519519
Then, run the following:
520520

docs/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ After reporting you should aim to answer questions or clarifications as this hel
4444

4545
## Donations
4646

47-
The best way to fund flameshot is to create a bounty here: https://rysolv.com/issues
47+
The best way to fund Flameshot is to create a bounty here: https://rysolv.com/issues

docs/RFC.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ project is evolving in.
3333
[When you need to follow this process]: #when-you-need-to-follow-this-process
3434

3535
You need to follow this process if you intend to make "substantial" changes to
36-
flameshot or the RFC process itself. What constitutes a
36+
Flameshot or the RFC process itself. What constitutes a
3737
"substantial" change is evolving based on community norms and varies depending
3838
on what part of the ecosystem you are proposing to change, but may include the
3939
following.
@@ -178,7 +178,7 @@ as a "very minor change" is up to the development team.
178178

179179
[Reviewing RFCs]: #reviewing-rfcs
180180

181-
The preferred method of discussing RFC's is the github issue. However, the development team may schedule meetings with the
181+
The preferred method of discussing RFC's is the Github issue. However, the development team may schedule meetings with the
182182
author and/or relevant stakeholders to discuss the issues in greater detail. In either
183183
case a summary from the meeting will be posted back to the RFC pull request.
184184

docs/Releasing.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
# Checklist for making a new release
22

3-
These are the code changes that need to take place
4-
- [ ] Update version in CMakeLists.txt
5-
- [ ] Update version and changelog at packaging/debian/changelog
6-
- [ ] Update version and changelog at packaging/rpm/flameshot.spec
7-
- [ ] Update data/appdata/flameshot.metainfo.xml
8-
- [ ] Update MacOs version in cmake/modules/MacOSXBundleInfo.plist.in
3+
These are the code changes that need to take place:
4+
- [ ] Update version in `CMakeLists.txt`
5+
- [ ] Update version and changelog at `packaging/debian/changelog`
6+
- [ ] Update version and changelog at `packaging/rpm/flameshot.spec`
7+
- [ ] Update `data/appdata/flameshot.metainfo.xml`
8+
- [ ] Update macOS version in `cmake/modules/MacOSXBundleInfo.plist.in`
99
- [ ] Commit and push to a PR
1010
- [ ] Merge PR to main
1111
- [ ] Create and push git tag on main
12-
- [ ] Manually retrigger the github actions so it uses the latest git tag
12+
- [ ] Manually retrigger the Github actions so it uses the latest git tag
1313

14-
These are the steps for actually making the release
14+
These are the steps for actually making the release:
1515
- [ ] Download all binaries from CI run started from PR related to code changes shown above
16-
- [ ] Create sha256 for each binary and compare against sha256 shown in the CI to verify there was no corruption or inserted malware.
17-
- [ ] Create a new "New Release" in github and explain changes in release notes
16+
- [ ] Create sha256 for each binary and compare against sha256 shown in the CI to verify there was no corruption or inserted malware
17+
- [ ] Create a new "New Release" in Github and explain changes in release notes
1818
- [ ] Upload all binaries and sha's
19-
- [ ] Update flatpak manifest for flathub: https://github.com/flathub/org.flameshot.Flameshot
19+
- [ ] Update flatpak manifest for Flathub: https://github.com/flathub/org.flameshot.Flameshot
2020
- [ ] Push snapcraft edge release to stable
2121
- [ ] If this is a major release coordinate with sign path on signed windows binaries
22-
- [ ] Update change log on [website](https://github.com/flameshot-org/flameshot-org.github.io/) data/changelog.md
22+
- [ ] Update change log on [website](https://github.com/flameshot-org/flameshot-org.github.io/) `data/changelog.md`
2323
- [ ] Update version on [website](https://github.com/flameshot-org/flameshot-org.github.io/blob/master/_coverpage.md)

docs/Sway and wlroots support.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ org.freedesktop.impl.portal.Screenshot=wlr
4848
Q) Flameshot doesn't take a screenshot, it just hangs!
4949

5050
A) Please ensure that the packages are installed, and that the variables are exported.
51-
This is usually caused by flameshot receiving no response from the desktop portal. This can be verified by running `dbus-monitor --session sender=org.freedesktop.portal.Desktop destination=org.freedesktop.portal.Desktop`.
51+
This is usually caused by Flameshot receiving no response from the desktop portal. This can be verified by running `dbus-monitor --session sender=org.freedesktop.portal.Desktop destination=org.freedesktop.portal.Desktop`.
5252

5353
Q) Flameshot takes one screenshot, then won't take anymore!
5454

5555
A) There is a bug in xdg-desktop-portal-wlr and Flameshot causing calls with the same token to fail. If you see a sdbus vtable error in the xdpw logs, either used the [patched version](https://github.com/nullobsi/xdg-desktop-portal-wlr/tree/improve-screenshot) or update Flameshot to the latest master.
5656

5757
# River wlroots support
5858

59-
Like mentioned above, flameshot now works on wlroots based Wayland compositors, however, there is a weird problem with river and that is when setting `XDG_CURRENT_DESKTOP=river`, flameshot won't work. The fix is you need to trick flameshot that you are on `sway`. Hence, you need to run river like so:
59+
Like mentioned above, Flameshot now works on wlroots based Wayland compositors, however, there is a weird problem with river and that is when setting `XDG_CURRENT_DESKTOP=river`, Flameshot won't work. The fix is you need to trick Flameshot that you are on `sway`. Hence, you need to run river like so:
6060

6161
```sh
6262
XDG_CURRENT_DESKTOP=sway dbus-run-session river
@@ -68,7 +68,7 @@ and add the following on your config such as in `$HOME/.config/river/init`
6868
riverctl float-filter-add "flameshot"
6969
```
7070

71-
Otherwise, flameshot will not take all of the screen and tiles its window instead like a normal application. Note however, that some clipboard stuff is broken so it might be good to save your screenshot as a file while having it copied to a clipboard in case if clipboard does some weird stuff like not pasting the overall screenshot.
71+
Otherwise, Flameshot will not take all of the screen and tiles its window instead like a normal application. Note however, that some clipboard stuff is broken so it might be good to save your screenshot as a file while having it copied to a clipboard in case if clipboard does some weird stuff like not pasting the overall screenshot.
7272

7373
#### For more information, please refer to https://github.com/emersion/xdg-desktop-portal-wlr/wiki/%22It-doesn't-work%22-Troubleshooting-Checklist
7474

0 commit comments

Comments
 (0)