Fix poor performance with Qt 6: Replace QFileSystemModel with QFileIconProvider (flameshot-org#3989)

Author: ElTh0r0

src/utils/winlnkfileparse.cpp

@@ -4,7 +4,7 @@
 #include "winlnkfileparse.h"
 #include <QDir>
 #include <QDirIterator>
-#include <QFileSystemModel>
+#include <QFileIconProvider>
 #include <QImageWriter>
 #include <QRegularExpression>
 #include <QSettings>
@@ -36,11 +36,8 @@ DesktopAppData WinLnkFileParser::parseLnkFile(const QFileInfo& fiLnk,
 
     res.name = fiLnk.baseName();
     res.exec = fiSymlink.absoluteFilePath();
-
-    // Get icon from exe
-    QFileSystemModel* model = new QFileSystemModel;
-    model->setRootPath(fiSymlink.path());
-    res.icon = model->fileIcon(model->index(fiSymlink.filePath()));
+    static QFileIconProvider provider;
+    res.icon = provider.icon(QFileInfo(fiSymlink.filePath()));
 
     if (m_GraphicAppsList.contains(fiSymlink.fileName())) {
         res.categories = QStringList() << "Graphics";

src/utils/winlnkfileparse.h

@@ -25,7 +25,7 @@ struct WinLnkFileParser
     WinLnkFileParser();
     DesktopAppData parseLnkFile(const QFileInfo& fiLnk, bool& ok) const;
     int processDirectory(const QDir& dir);
-    QString getAllUsersStartMenuPath();
+    static QString getAllUsersStartMenuPath();
 
     QVector<DesktopAppData> getAppsByCategory(const QString& category);
     QMap<QString, QVector<DesktopAppData>> getAppsByCategory(