Skip to content

Commit 68594db

Browse files
authored
fix: add missing appstream data for flatpak builder (flameshot-org#3911)
Commit updates appstream data to pass strict validation, which is necessary to build new Flatpak versions. Flatpak builder added strict validation and requires "developer" information [1] to be provided. Build error: ``` Run docker run --rm --privileged \ + flatpak-builder-lint --exceptions repo repo { "errors": [ "appstream-missing-developer-name" ], "warnings": [ "appstream-screenshot-missing-caption" ], "info": [ "appstream-screenshot-missing-caption: One or more screenshots are missing captions in the Metainfo file", "appstream-missing-developer-name: No developer tag found in Metainfo file" ], "message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter" } error: Recipe `validate-build` failed with exit code 1 ``` For good measure, captions for the provided screenshots are added. After changes made, `appstreamcli validate` only mentions issue with uppercase cid component which should be kept as is: ```sh $ appstreamcli validate --pedantic data/appdata/org.flameshot.Flameshot.metainfo.xml P: org.flameshot.Flameshot:7: cid-contains-uppercase-letter org.flameshot.Flameshot ✔ Validation was successful: pedantic: 1 ``` [1]: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines#developer-name
1 parent b35f977 commit 68594db

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

data/appdata/org.flameshot.Flameshot.metainfo.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ SPDX-License-Identifier: CC0-1.0
88
<metadata_license>CC0-1.0</metadata_license>
99
<project_license>GPL-3.0-or-later</project_license>
1010
<name>Flameshot</name>
11+
<developer id="org.flameshot">
12+
<name>Flameshot Developers</name>
13+
</developer>
1114
<releases>
1215
<release version="12.1.0" date="2022-07-03"/>
1316
<release version="12.0.0" date="2022-06-21"/>
@@ -33,9 +36,11 @@ SPDX-License-Identifier: CC0-1.0
3336
<screenshots>
3437
<screenshot type="default">
3538
<image>https://raw.githubusercontent.com/flameshot-org/flameshot/master/data/img/preview/usageStatic.png</image>
39+
<caption>Flameshot Usage</caption>
3640
</screenshot>
3741
<screenshot>
3842
<image>https://raw.githubusercontent.com/flameshot-org/flameshot/master/data/img/preview/animatedUsage.gif</image>
43+
<caption>Animated Flameshot Usage</caption>
3944
</screenshot>
4045
</screenshots>
4146
<url type="homepage">https://github.com/flameshot-org/flameshot</url>

0 commit comments

Comments
 (0)