Commit 68594db
authored
fix: add missing appstream data for flatpak builder (flameshot-org#3911)
Commit updates appstream data to pass strict validation, which is necessary to build new Flatpak versions.
Flatpak builder added strict validation and requires "developer" information [1] to be provided.
Build error:
```
Run docker run --rm --privileged \
+ flatpak-builder-lint --exceptions repo repo
{
"errors": [
"appstream-missing-developer-name"
],
"warnings": [
"appstream-screenshot-missing-caption"
],
"info": [
"appstream-screenshot-missing-caption: One or more screenshots
are missing captions in the Metainfo file",
"appstream-missing-developer-name: No developer tag found in
Metainfo file"
],
"message": "Please consult the documentation at
https://docs.flathub.org/docs/for-app-authors/linter"
}
error: Recipe `validate-build` failed with exit code 1
```
For good measure, captions for the provided screenshots are added.
After changes made, `appstreamcli validate` only mentions issue with uppercase cid component which should be kept as is:
```sh
$ appstreamcli validate --pedantic data/appdata/org.flameshot.Flameshot.metainfo.xml
P: org.flameshot.Flameshot:7: cid-contains-uppercase-letter org.flameshot.Flameshot
✔ Validation was successful: pedantic: 1
```
[1]: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines#developer-name1 parent b35f977 commit 68594db
1 file changed
+5
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
11 | 14 | | |
12 | 15 | | |
13 | 16 | | |
| |||
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
| 39 | + | |
36 | 40 | | |
37 | 41 | | |
38 | 42 | | |
| 43 | + | |
39 | 44 | | |
40 | 45 | | |
41 | 46 | | |
| |||
0 commit comments