Skip to content

Commit 081fa22

Browse files
committed
refactor: correct naming of new function
1 parent ca67d3f commit 081fa22

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

freqtrade/data/btanalysis/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
trade_list_to_dataframe,
2626
update_backtest_metadata,
2727
)
28-
from .historic_precision import get_significant_digits_over_time
28+
from .historic_precision import get_tick_size_over_time
2929
from .trade_parallelism import (
3030
analyze_trade_parallelism,
3131
evaluate_result_multi,

freqtrade/data/btanalysis/historic_precision.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from pandas import DataFrame, Series
22

33

4-
def get_significant_digits_over_time(candles: DataFrame) -> Series:
4+
def get_tick_size_over_time(candles: DataFrame) -> Series:
55
"""
66
Calculate the number of significant digits for candles over time.
77
It's using the Monthly maximum of the number of significant digits for each month.

freqtrade/optimize/backtesting.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from freqtrade.data import history
1919
from freqtrade.data.btanalysis import (
2020
find_existing_backtest_stats,
21-
get_significant_digits_over_time,
21+
get_tick_size_over_time,
2222
trade_list_to_dataframe,
2323
)
2424
from freqtrade.data.converter import trim_dataframe, trim_dataframes
@@ -323,7 +323,8 @@ def load_bt_data(self) -> tuple[dict[str, DataFrame], TimeRange]:
323323
self.price_pair_prec = {}
324324
for pair in self.pairlists.whitelist:
325325
if pair in data:
326-
self.price_pair_prec[pair] = get_significant_digits_over_time(data[pair])
326+
# Load price precision logic
327+
self.price_pair_prec[pair] = get_tick_size_over_time(data[pair])
327328
return data, self.timerange
328329

329330
def _load_bt_data_detail(self) -> None:

tests/data/test_historic_precision.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
from numpy import nan
77
from pandas import DataFrame, Timestamp
88

9-
from freqtrade.data.btanalysis.historic_precision import get_significant_digits_over_time
9+
from freqtrade.data.btanalysis.historic_precision import get_tick_size_over_time
1010

1111

12-
def test_get_significant_digits_over_time():
12+
def test_get_tick_size_over_time():
1313
"""
14-
Test the get_significant_digits_over_time function with predefined data
14+
Test the get_tick_size_over_time function with predefined data
1515
"""
1616
# Create test dataframe with different levels of precision
1717
data = {
@@ -36,7 +36,7 @@ def test_get_significant_digits_over_time():
3636
candles = DataFrame(data)
3737

3838
# Calculate significant digits
39-
result = get_significant_digits_over_time(candles)
39+
result = get_tick_size_over_time(candles)
4040

4141
# Check that the result is a pandas Series
4242
assert isinstance(result, pd.Series)
@@ -60,9 +60,9 @@ def test_get_significant_digits_over_time():
6060
assert result.iloc[0] == 0.00001
6161

6262

63-
def test_get_significant_digits_over_time_real_data(testdatadir):
63+
def test_get_tick_size_over_time_real_data(testdatadir):
6464
"""
65-
Test the get_significant_digits_over_time function with real data from the testdatadir
65+
Test the get_tick_size_over_time function with real data from the testdatadir
6666
"""
6767
from freqtrade.data.history import load_pair_history
6868

@@ -80,7 +80,7 @@ def test_get_significant_digits_over_time_real_data(testdatadir):
8080
assert not candles.empty, "No test data found, cannot run test"
8181

8282
# Calculate significant digits
83-
result = get_significant_digits_over_time(candles)
83+
result = get_tick_size_over_time(candles)
8484

8585
assert isinstance(result, pd.Series)
8686

0 commit comments

Comments
 (0)