test: add test for improved safe_wrapper behavior

Author: xmatthias

tests/strategy/test_strategy_safe_wrapper.py

@@ -3,8 +3,11 @@
 from freqtrade.exceptions import StrategyError
 from freqtrade.persistence import Trade
 from freqtrade.strategy.strategy_wrapper import strategy_safe_wrapper
+from freqtrade.util.datetime_helpers import dt_now
 from tests.conftest import create_mock_trades, log_has_re
 
+from .strats.strategy_test_v3 import StrategyTestV3
+
 
 @pytest.mark.parametrize(
     "error",
@@ -47,9 +50,14 @@ def working_method(argumentpassedin):
 
 
 @pytest.mark.usefixtures("init_persistence")
-def test_strategy_safe_wrapper_trade_copy(fee):
+def test_strategy_safe_wrapper_trade_copy(fee, mocker):
     create_mock_trades(fee)
+    import freqtrade.strategy.strategy_wrapper as swm
+
+    deepcopy_mock = mocker.spy(swm, "deepcopy")
+
     trade_ = Trade.get_open_trades()[0]
+    strat = StrategyTestV3(config={})
 
     def working_method(trade):
         assert len(trade.orders) > 0
@@ -59,11 +67,27 @@ def working_method(trade):
         assert id(trade_) != id(trade)
         return trade
 
+    strat.working_method = working_method
+
     # Don't assert anything before strategy_wrapper.
     # This ensures that relationship loading works correctly.
-    ret = strategy_safe_wrapper(working_method, message="DeadBeef")(trade=trade_)
+    ret = strategy_safe_wrapper(strat.working_method, message="DeadBeef")(trade=trade_)
     assert isinstance(ret, Trade)
     assert id(trade_) != id(ret)
     # Did not modify the original order
     assert len(trade_.orders) > 0
     assert len(ret.orders) == 0
+    assert deepcopy_mock.call_count == 1
+    deepcopy_mock.reset_mock()
+
+    # Call with non-overridden method - shouldn't deep-copy the trade
+    ret = strategy_safe_wrapper(strat.custom_entry_price, message="DeadBeef")(
+        pair="ETH/USDT",
+        trade=trade_,
+        current_time=dt_now(),
+        proposed_rate=0.5,
+        entry_tag="",
+        side="long",
+    )
+
+    assert deepcopy_mock.call_count == 0