Skip to content

Commit 56a8fb4

Browse files
authored
Merge pull request freqtrade#12532 from stash86/bitget-delist
add delisting check for bitget futures
2 parents 3f782fc + d02e5f2 commit 56a8fb4

File tree

2 files changed

+79
-5
lines changed

2 files changed

+79
-5
lines changed

freqtrade/exchange/bitget.py

Lines changed: 36 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import logging
2-
from datetime import timedelta
2+
from datetime import datetime, timedelta
33

44
import ccxt
55

66
from freqtrade.constants import BuySell
7-
from freqtrade.enums import CandleType, MarginMode, TradingMode
7+
from freqtrade.enums import OPTIMIZE_MODES, CandleType, MarginMode, TradingMode
88
from freqtrade.exceptions import (
99
DDosProtection,
1010
OperationalException,
@@ -14,7 +14,7 @@
1414
from freqtrade.exchange import Exchange
1515
from freqtrade.exchange.common import API_RETRY_COUNT, retrier
1616
from freqtrade.exchange.exchange_types import CcxtOrder, FtHas
17-
from freqtrade.util.datetime_helpers import dt_now, dt_ts
17+
from freqtrade.util import dt_from_ts, dt_now, dt_ts
1818

1919

2020
logger = logging.getLogger(__name__)
@@ -37,6 +37,7 @@ class Bitget(Exchange):
3737
_ft_has_futures: FtHas = {
3838
"mark_ohlcv_timeframe": "4h",
3939
"funding_fee_candle_limit": 100,
40+
"has_delisting": True,
4041
}
4142

4243
_supported_trading_mode_margin_pairs: list[tuple[TradingMode, MarginMode]] = [
@@ -236,3 +237,35 @@ def dry_run_liquidation_price(
236237
raise OperationalException(
237238
"Freqtrade currently only supports isolated futures for bitget"
238239
)
240+
241+
def check_delisting_time(self, pair: str) -> datetime | None:
242+
"""
243+
Check if the pair gonna be delisted.
244+
By default, it returns None.
245+
:param pair: Market symbol
246+
:return: Datetime if the pair gonna be delisted, None otherwise
247+
"""
248+
if self._config["runmode"] in OPTIMIZE_MODES:
249+
return None
250+
251+
if self.trading_mode == TradingMode.FUTURES:
252+
return self._check_delisting_futures(pair)
253+
return None
254+
255+
def _check_delisting_futures(self, pair: str) -> datetime | None:
256+
delivery_time = self.markets.get(pair, {}).get("info", {}).get("limitOpenTime", None)
257+
if delivery_time:
258+
if isinstance(delivery_time, str) and (delivery_time != ""):
259+
delivery_time = int(delivery_time)
260+
261+
if not isinstance(delivery_time, int) or delivery_time <= 0:
262+
return None
263+
264+
max_delivery = dt_ts() + (
265+
14 * 24 * 60 * 60 * 1000
266+
) # Assume exchange don't announce delisting more than 14 days in advance
267+
268+
if delivery_time < max_delivery:
269+
return dt_from_ts(delivery_time)
270+
271+
return None

tests/exchange/test_bitget.py

Lines changed: 43 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1+
from copy import deepcopy
12
from datetime import timedelta
23
from unittest.mock import MagicMock, PropertyMock
34

45
import pytest
56

6-
from freqtrade.enums import CandleType, MarginMode, TradingMode
7+
from freqtrade.enums import CandleType, MarginMode, RunMode, TradingMode
78
from freqtrade.exceptions import OperationalException, RetryableOrderError
89
from freqtrade.exchange.common import API_RETRY_COUNT
9-
from freqtrade.util import dt_now, dt_ts
10+
from freqtrade.util import dt_now, dt_ts, dt_utc
1011
from tests.conftest import EXMS, get_patched_exchange
1112
from tests.exchange.test_exchange import ccxt_exceptionhandlers
1213

@@ -193,3 +194,43 @@ def test__lev_prep_bitget(default_conf, mocker):
193194
assert api_mock.set_margin_mode.call_count == 0
194195
assert api_mock.set_leverage.call_count == 1
195196
api_mock.set_leverage.assert_called_with(symbol="BTC/USDC:USDC", leverage=19.99)
197+
198+
199+
def test_check_delisting_time_bitget(default_conf_usdt, mocker):
200+
exchange = get_patched_exchange(mocker, default_conf_usdt, exchange="bitget")
201+
exchange._config["runmode"] = RunMode.BACKTEST
202+
delist_fut_mock = MagicMock(return_value=None)
203+
mocker.patch.object(exchange, "_check_delisting_futures", delist_fut_mock)
204+
205+
# Invalid run mode
206+
resp = exchange.check_delisting_time("BTC/USDT")
207+
assert resp is None
208+
assert delist_fut_mock.call_count == 0
209+
210+
# Delist spot called
211+
exchange._config["runmode"] = RunMode.DRY_RUN
212+
resp1 = exchange.check_delisting_time("BTC/USDT")
213+
assert resp1 is None
214+
assert delist_fut_mock.call_count == 0
215+
216+
# Delist futures called
217+
exchange.trading_mode = TradingMode.FUTURES
218+
resp1 = exchange.check_delisting_time("BTC/USDT:USDT")
219+
assert resp1 is None
220+
assert delist_fut_mock.call_count == 1
221+
222+
223+
def test__check_delisting_futures_bitget(default_conf_usdt, mocker, markets):
224+
markets["BTC/USDT:USDT"] = deepcopy(markets["SOL/BUSD:BUSD"])
225+
markets["BTC/USDT:USDT"]["info"]["limitOpenTime"] = "-1"
226+
markets["SOL/BUSD:BUSD"]["info"]["limitOpenTime"] = "-1"
227+
markets["ADA/USDT:USDT"]["info"]["limitOpenTime"] = "1760745600000" # 2025-10-18
228+
exchange = get_patched_exchange(mocker, default_conf_usdt, exchange="bitget")
229+
mocker.patch(f"{EXMS}.markets", PropertyMock(return_value=markets))
230+
231+
resp_sol = exchange._check_delisting_futures("SOL/BUSD:BUSD")
232+
# No delisting date
233+
assert resp_sol is None
234+
# Has a delisting date
235+
resp_ada = exchange._check_delisting_futures("ADA/USDT:USDT")
236+
assert resp_ada == dt_utc(2025, 10, 18)

0 commit comments

Comments
 (0)