Skip to content

Commit 60029c2

Browse files
committed
fix: improved message when nonexisting trade is deleted
part of freqtrade#11967
1 parent 14429d4 commit 60029c2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

freqtrade/rpc/rpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1094,7 +1094,7 @@ def _rpc_delete(self, trade_id: int) -> dict[str, str | int]:
10941094
trade = Trade.get_trades(trade_filter=[Trade.id == trade_id]).first()
10951095
if not trade:
10961096
logger.warning("delete trade: Invalid argument received")
1097-
raise RPCException("invalid argument")
1097+
raise RPCException(f"Trade with id '{trade_id}' not found.")
10981098

10991099
# Try cancelling regular order if that exists
11001100
for open_order in trade.open_orders:

tests/rpc/test_rpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ def test_rpc_delete_trade(mocker, default_conf, fee, markets, caplog, is_short):
393393
freqtradebot.strategy.order_types["stoploss_on_exchange"] = True
394394
create_mock_trades(fee, is_short)
395395
rpc = RPC(freqtradebot)
396-
with pytest.raises(RPCException, match="invalid argument"):
396+
with pytest.raises(RPCException, match="Trade with id '200' not found."):
397397
rpc._rpc_delete("200")
398398

399399
trades = Trade.session.scalars(select(Trade)).all()

0 commit comments

Comments
 (0)