chore: make some internal fetch-trades methods require since

Author: xmatthias

freqtrade/data/history/history_utils.py

@@ -444,7 +444,7 @@ def _download_trades_history(
     if not trades.empty and since < trades.iloc[-1]["timestamp"]:
         # Reset since to the last available point
         # - 5 seconds (to ensure we're getting all trades)
-        since = trades.iloc[-1]["timestamp"] - (5 * 1000)
+        since = int(trades.iloc[-1]["timestamp"] - (5 * 1000))
         logger.info(
             f"Using last trade date -5s - Downloading trades for {pair} "
             f"since: {format_ms_time(since)}."

freqtrade/exchange/binance.py

@@ -363,7 +363,7 @@ def load_leverage_tiers(self) -> dict[str, list[dict]]:
             return {}
 
     async def _async_get_trade_history_id_startup(
-        self, pair: str, since: int | None
+        self, pair: str, since: int
     ) -> tuple[list[list], str]:
         """
         override for initial call

freqtrade/exchange/exchange.py

@@ -2960,15 +2960,15 @@ def _get_trade_pagination_next_value(self, trades: list[dict]):
             return trades[-1].get("timestamp")
 
     async def _async_get_trade_history_id_startup(
-        self, pair: str, since: int | None
+        self, pair: str, since: int
     ) -> tuple[list[list], str]:
         """
         override for initial trade_history_id call
         """
         return await self._async_fetch_trades(pair, since=since)
 
     async def _async_get_trade_history_id(
-        self, pair: str, until: int, since: int | None = None, from_id: str | None = None
+        self, pair: str, *, until: int, since: int, from_id: str | None = None
     ) -> tuple[str, list[list]]:
         """
         Asynchronously gets trade history using fetch_trades
@@ -3022,7 +3022,7 @@ async def _async_get_trade_history_id(
         return (pair, trades)
 
     async def _async_get_trade_history_time(
-        self, pair: str, until: int, since: int | None = None
+        self, pair: str, until: int, since: int
     ) -> tuple[str, list[list]]:
         """
         Asynchronously gets trade history using fetch_trades,
@@ -3063,7 +3063,7 @@ async def _async_get_trade_history_time(
     async def _async_get_trade_history(
         self,
         pair: str,
-        since: int | None = None,
+        since: int,
         until: int | None = None,
         from_id: str | None = None,
     ) -> tuple[str, list[list]]:
@@ -3094,7 +3094,7 @@ async def _async_get_trade_history(
     def get_historic_trades(
         self,
         pair: str,
-        since: int | None = None,
+        since: int,
         until: int | None = None,
         from_id: str | None = None,
     ) -> tuple[str, list]: