Skip to content

Commit f82d8f3

Browse files
committed
test: refactor _get_params test for simpler reading
1 parent 1f62025 commit f82d8f3

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

tests/exchange/test_exchange.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5942,32 +5942,32 @@ def test_get_max_leverage_futures(default_conf, mocker, leverage_tiers):
59425942
assert exchange.get_max_leverage("TIA/USDT:USDT", 130.008) == 40
59435943

59445944

5945-
@pytest.mark.parametrize("exchange_name", ["binance", "kraken", "gate", "okx", "bybit", "bitget"])
5946-
def test__get_params(mocker, default_conf, exchange_name):
5945+
@pytest.mark.parametrize(
5946+
"exchange_name, add_params_spot, add_params_futures",
5947+
[
5948+
("binance", {}, {}),
5949+
("kraken", {}, {"leverage": 3.0}),
5950+
("gate", {}, {}),
5951+
("okx", {}, {"tdMode": "isolated", "posSide": "net"}),
5952+
("bybit", {}, {"position_idx": 0}),
5953+
("bitget", {}, {"marginMode": "isolated"}),
5954+
],
5955+
)
5956+
def test__get_params(mocker, default_conf, exchange_name, add_params_spot, add_params_futures):
59475957
api_mock = MagicMock()
59485958
mocker.patch(f"{EXMS}.exchange_has", return_value=True)
59495959
exchange = get_patched_exchange(mocker, default_conf, api_mock, exchange=exchange_name)
59505960
exchange._params = {"test": True}
59515961

59525962
params1 = {"test": True}
5953-
params2 = {
5963+
params1.update(add_params_spot)
5964+
5965+
params_fut = {
59545966
"test": True,
59555967
"timeInForce": "IOC",
59565968
"reduceOnly": True,
59575969
}
5958-
5959-
if exchange_name == "kraken":
5960-
params2["leverage"] = 3.0
5961-
5962-
if exchange_name == "okx":
5963-
params2["tdMode"] = "isolated"
5964-
params2["posSide"] = "net"
5965-
5966-
if exchange_name == "bybit":
5967-
params2["position_idx"] = 0
5968-
5969-
if exchange_name == "bitget":
5970-
params2["marginMode"] = "isolated"
5970+
params_fut.update(add_params_futures)
59715971

59725972
assert (
59735973
exchange._get_params(
@@ -6015,7 +6015,7 @@ def test__get_params(mocker, default_conf, exchange_name):
60156015
time_in_force="IOC",
60166016
leverage=3.0,
60176017
)
6018-
== params2
6018+
== params_fut
60196019
)
60206020

60216021

0 commit comments

Comments
 (0)