fix(desktop): disk space detection (hoppscotch#5019)

This fix replace `sys-info v0.9.1` with
the more actively maintained `sysinfo 0.34.2`
which does return size of the disk in bytes.

Closes hoppscotch#5017, HFE-831

Rebased on hoppscotch#5010, consider merging that first.

Issues:

Appload fails to load with a "Storage full" error despite
having sufficient disk space.

This was caused by a unit mismatch in the `sys-info` crate
which returns disk space in kilobytes instead of bytes.

- sys_info::disk_info() returns values in KB, see:
  https://github.com/FillZpp/sys-info-rs/blob/60ecf1470a5b7c90242f429934a3bacb6023ec4d/c/linux.c#L119
- The `StorageFull` error was triggered when comparing
  raw bytes against a KB value, causing false positive

Changes:
- Rewrite the `ensure_space` function to find the correct disk of the config dir
- Add a new `StorageError::DiskNotFound` for cases where the disk cannot
  be resolved

Author: CuriousCorrelation

packages/hoppscotch-desktop/plugin-workspace/tauri-plugin-appload/Cargo.lock

@@ -28,7 +28,7 @@ blake3 = { version = "1.5.4", features = ["serde"] }
 ed25519-dalek = { version = "2.1.1", features = ["rand_core", "serde"] }
 hex = "0.4.3"
 lru = "0.12.5"
-sys-info = "0.9.1"
+sysinfo = "0.34.2"
 humantime-serde = "1.1.1"
 futures = "0.3.31"
 mime_guess = "2.0.5"

packages/hoppscotch-desktop/plugin-workspace/tauri-plugin-appload/Cargo.toml

@@ -11,6 +11,9 @@ pub enum StorageError {
     #[error("Invalid path: {0}")]
     InvalidPath(String),
 
+    #[error("Disk not found: fatal error, unable to resolve user config storage disk")]
+    DiskNotFound,
+
     #[error("Storage full: required {required} bytes, available {available} bytes")]
     StorageFull { required: u64, available: u64 },
 

packages/hoppscotch-desktop/plugin-workspace/tauri-plugin-appload/src/storage/error.rs

@@ -1,7 +1,7 @@
 use std::path::PathBuf;
 
 pub struct StorageLayout {
-    root: PathBuf,
+    pub(crate) root: PathBuf,
 }
 
 impl StorageLayout {

packages/hoppscotch-desktop/plugin-workspace/tauri-plugin-appload/src/storage/layout.rs

@@ -1,5 +1,6 @@
 use std::path::PathBuf;
 use std::sync::Arc;
+use sysinfo::Disks;
 use tokio::sync::RwLock;
 use tracing;
 
@@ -144,12 +145,27 @@ impl StorageManager {
 
     async fn ensure_space(&self, required: usize) -> Result<()> {
         tracing::debug!(required_space = required, "Checking available disk space");
-        let available = sys_info::disk_info()
-            .map_err(|e| {
-                tracing::error!(error = %e, "Failed to retrieve disk information");
-                StorageError::OtherError(format!("Failed to get disk info: {}", e))
-            })?
-            .free;
+
+        let disks = Disks::new_with_refreshed_list();
+
+        let storage_path = self.layout.root.canonicalize().map_err(|e| {
+            tracing::error!(error = %e, "Failed to resolve storage path");
+            StorageError::Io(e)
+        })?;
+
+        // NOTE: There cannot be more than one user config storage disk,
+        // although even if there is, defaulting to the first one we found
+        // is as good of a guess as any.
+        let disk = disks
+            .into_iter()
+            .find(|disk| storage_path.starts_with(disk.mount_point()));
+
+        let Some(disk) = disk else {
+            tracing::error!("Fatal error, unable to resolve user config storage disk");
+            return Err(StorageError::DiskNotFound);
+        };
+
+        let available = disk.available_space();
 
         if (required as u64) > available {
             tracing::warn!(