fix: add fallback for isSecret key (hoppscotch#5157)

nivedin · web-flow · commit 44d5289a2dfd · 2025-06-16T18:22:52.000+05:30
diff --git a/packages/hoppscotch-common/src/components/environments/my/Details.vue b/packages/hoppscotch-common/src/components/environments/my/Details.vue
@@ -460,7 +460,7 @@ const saveEnvironment = () => {
             key: e.key,
             currentValue: e.currentValue,
             varIndex: i,
-            isSecret: e.secret,
+            isSecret: e.secret ?? false,
           })
         : O.none
     )
diff --git a/packages/hoppscotch-common/src/components/environments/teams/Details.vue b/packages/hoppscotch-common/src/components/environments/teams/Details.vue
@@ -426,7 +426,7 @@ const saveEnvironment = async () => {
             key: e.key,
             currentValue: e.currentValue,
             varIndex: i,
-            isSecret: e.secret,
+            isSecret: e.secret ?? false,
           })
         : O.none
     )
diff --git a/packages/hoppscotch-common/src/helpers/RequestRunner.ts b/packages/hoppscotch-common/src/helpers/RequestRunner.ts
@@ -164,7 +164,7 @@ const updateEnvironments = (
 
       nonSecretVariables.push({
         key: e.key,
-        isSecret: e.secret,
+        isSecret: e.secret ?? false,
         varIndex: index,
         currentValue: e.currentValue ?? "",
       })
diff --git a/packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts b/packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts
@@ -386,7 +386,7 @@ export const CURRENT_ENVIRONMENT_VALUE_SCHEMA = z.union([
           key: z.string(),
           currentValue: z.string(),
           varIndex: z.number(),
-          isSecret: z.boolean(),
+          isSecret: z.boolean().catch(false),
         })
         .strict()
     )

Original file line number	Diff line number	Diff line change
`@@ -460,7 +460,7 @@ const saveEnvironment = () => {`
`460`	`460`	`key: e.key,`
`461`	`461`	`currentValue: e.currentValue,`
`462`	`462`	`varIndex: i,`
`463`		`- isSecret: e.secret,`
	`463`	`+ isSecret: e.secret ?? false,`
`464`	`464`	`})`
`465`	`465`	`: O.none`
`466`	`466`	`)`
Original file line number	Diff line number	Diff line change
`@@ -426,7 +426,7 @@ const saveEnvironment = async () => {`
`426`	`426`	`key: e.key,`
`427`	`427`	`currentValue: e.currentValue,`
`428`	`428`	`varIndex: i,`
`429`		`- isSecret: e.secret,`
	`429`	`+ isSecret: e.secret ?? false,`
`430`	`430`	`})`
`431`	`431`	`: O.none`
`432`	`432`	`)`
Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,7 @@ export const CURRENT_ENVIRONMENT_VALUE_SCHEMA = z.union([`
`386`	`386`	`key: z.string(),`
`387`	`387`	`currentValue: z.string(),`
`388`	`388`	`varIndex: z.number(),`
`389`		`- isSecret: z.boolean(),`
	`389`	`+ isSecret: z.boolean().catch(false),`
`390`	`390`	`})`
`391`	`391`	`.strict()`
`392`	`392`	`)`