Skip to content

Commit 919eeac

Browse files
fix: correctly resolve request variables during collection runs (hoppscotch#5313)
Co-authored-by: jamesgeorge007 <[email protected]>
1 parent 43c025f commit 919eeac

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

packages/hoppscotch-common/src/helpers/RequestRunner.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,17 @@ export function runTestRunnerRequest(
587587
return E.left("script_fail" as const)
588588
}
589589

590+
const finalRequestVariables = pipe(
591+
request.requestVariables,
592+
A.filter(({ active }) => active),
593+
A.map(({ key, value }) => ({
594+
key,
595+
initialValue: value,
596+
currentValue: value,
597+
secret: false,
598+
}))
599+
)
600+
590601
const effectiveRequest = await getEffectiveRESTRequest(request, {
591602
id: "env-id",
592603
v: 2,
@@ -597,7 +608,7 @@ export function runTestRunnerRequest(
597608
...preRequestScriptResult.right.envs,
598609
temp: !persistEnv ? getTemporaryVariables() : [],
599610
},
600-
requestVariables: [],
611+
requestVariables: finalRequestVariables,
601612
})
602613
),
603614
})

0 commit comments

Comments
 (0)