Skip to content

Commit 65aadb7

Browse files
committed
fix: out of focus warning sometimes showing even though words were focused
1 parent ee2e680 commit 65aadb7

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

frontend/src/ts/commandline/commandline.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function removeCommandlineBackground(): void {
6464

6565
function addCommandlineBackground(): void {
6666
qs("#commandLine")?.removeClass("noBackground");
67-
if (Config.showOutOfFocusWarning && !isInputElementFocused()) {
67+
if (!isInputElementFocused()) {
6868
OutOfFocus.show();
6969
}
7070
}

frontend/src/ts/test/out-of-focus.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as Misc from "../utils/misc";
2+
import Config from "../config";
23

34
const outOfFocusTimeouts: (number | NodeJS.Timeout)[] = [];
45

@@ -11,6 +12,7 @@ export function hide(): void {
1112
}
1213

1314
export function show(): void {
15+
if (!Config.showOutOfFocusWarning) return;
1416
outOfFocusTimeouts.push(
1517
setTimeout(() => {
1618
$("#words, #compositionDisplay")

frontend/src/ts/test/test-ui.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ function updateWordWrapperClasses(): void {
465465
void updateHintsPositionDebounced();
466466
Caret.updatePosition();
467467

468-
if (document.activeElement !== getInputElement()) {
468+
if (!isInputElementFocused()) {
469469
OutOfFocus.show();
470470
}
471471
}
@@ -1998,7 +1998,7 @@ $("#wordsInput").on("focus", (e) => {
19981998
});
19991999

20002000
$("#wordsInput").on("focusout", () => {
2001-
if (!TestState.resultVisible && Config.showOutOfFocusWarning) {
2001+
if (!isInputElementFocused()) {
20022002
OutOfFocus.show();
20032003
}
20042004
Caret.hide();

0 commit comments

Comments
 (0)